Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement getters for construction parameters in all Shapes #11

Merged
merged 1 commit into from
Sep 12, 2015
Merged

Implement getters for construction parameters in all Shapes #11

merged 1 commit into from
Sep 12, 2015
+155 −2

Conversation

Squareys
Copy link
Contributor

@Squareys Squareys commented Sep 7, 2015

Hello everybody, Hello @tpietzsch !

I implemented the changes suggested in #5.

Greetings, Squareys

@dietzc
Copy link
Member

dietzc commented Sep 10, 2015

I'm wondering if there could be a public Interval getBoundingBox() method for each Shape, instead of providing getSpan or getRadius. It just feels a bit more consistent? @tpietzsch does this make sense?

@Squareys
Copy link
Contributor Author

@dietzc See #5 for previous discussion. Both could be provided. I only implemented the one, since it is directly relevant for what I'm working on in imagej-ops.

dietzc added a commit that referenced this pull request Sep 12, 2015
@dietzc
Merge pull request #11 from Squareys/shape-parameter-access
60d847b 
Implement getters for construction parameters in all Shapes
@dietzc dietzc merged commit 60d847b into imglib:master Sep 12, 2015
@dietzc
Copy link
Member

dietzc commented Sep 12, 2015

thanks @Squareys

1 similar comment
@tpietzsch
Copy link
Member

thanks @Squareys

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Squareys @dietzc @tpietzsch @tinevez