Enforce strict #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…teps in GitHub Workflows (oppia#20907) * Allow naming of merge from develop steps in GitHub Workflows * Modify existing test for merge step * Add a linter to require that all GitHub workflow steps be named * Add tests for requiring steps to be named and fix minor details in merge step test * Add names for workflow steps * Fix grammar mistakes in comments --------- Co-authored-by: Sean Lip <[email protected]> Co-authored-by: Akhilesh Kr. <[email protected]>
) * Updates * Updates * Updates * Updates * Updates * Updates * Updates * Updates * Updates * Updates * Updates * Updates * Updates * Updates --------- Co-authored-by: Hardik Goyal <[email protected]> Co-authored-by: Akhilesh Kr. <[email protected]>
* makefile fixed * Explaining comments * Explaining FIXED_PATH with comments * removed extra comment --------- Co-authored-by: Hardik Goyal <[email protected]> Co-authored-by: Akhilesh Kr. <[email protected]>
…ing for invalid method using 405 status code. (oppia#20544) * Added no 500 error tests for post put and delete. Also added 405 status code handling for invalid requests. * Fixed linting issues * Fixed more linting issues * Fixed even more linting issues * Fixed MyPy issues * Fixed linting issues * Fixed backend test error and updated 405 error message. * Fixed linting errors * Fixed linting errors * Added requested formatting change Co-authored-by: Vojtěch Jelínek <[email protected]> * Added requested formatting changes * Made changes so that load_templates is only used for GET * Made the requested changes * Fixed linting issue * Fixed failing backend test, made assertion for http_method neater * Fixed backend test and made requested changes * Fixed Mypy check error * Fixed Mypy error by importing Any from typing * Fixed linting errors * Added comment to address why type Any is used * Made requested changes in profile_test * Updated comment about mock_add_user_to_raise_exception in profile_test * Updated comment about mock_add_user_to_raise_exception in profile_test * Made requested changes * Fixed failing backend, linter and MyPy tests * Fixed failing linter tests * Fixed failing linter tests * Fixed failing MyPy tests * Added comment * Fixed linting issues * Added correct types in profile_test * Corrected if block and typo * Added test to fix failing backend coverage * Fixed linting issues * Fixed Mypy issues --------- Co-authored-by: Vojtěch Jelínek <[email protected]> Co-authored-by: Sean Lip <[email protected]> Co-authored-by: Akhilesh Kr. <[email protected]>
* Fix part of#19849: Multiple classrooms bug fixes * fix classrooms page alignment * nit * add classroom name and url fragment * fix type * add classroom name * show classroom name * fix test * fix overflow --------- Co-authored-by: Hardik Goyal <[email protected]> Co-authored-by: Akhilesh Kr. <[email protected]>
* review tests page migration * *lint fix * lint fix * Reverting import changes --------- Co-authored-by: Akhilesh Kr. <[email protected]> Co-authored-by: Hardik Goyal <[email protected]>
* trying to debug * debugging * fixed the issue * code cleanup --------- Co-authored-by: StephenYu2018 <[email protected]>
… screen in progress tab for learner dashboard redesign (oppia#20929) * Updated large button class * Added button default color classes * Added classroom button * Replaced home classroom button with new component * Moved classes to classroom button & added empty classes to progress * Added i18n keys and empty progress * Fixed classroom button width * Added spec * Added content toggle html and ts * Added translation keys and toggle * Dynamic i18n button text & style for content-toggle, replaced button in card-display with content-toggle * Updated test files for classroom button * Added content toggle test cases * Added card display test * Added card display test cases * Fixed bugs in test cases * Fixed linter issues * Fixed spacing for icons and text RTL * Added unit tests for isLearnerStateEmpty * Addressed comments on testing and functions * Replaced :host with alternative styling and moved toggleVisibility to .ts * Changed toggleState variable name and updated test cases for hostlistener * Corrected card display tests * Removed extra variable * Added new line * Renamed event emitter
* Update core/feconf.py * Update package.json --------- Co-authored-by: github-actions[bot] <[email protected]>
…#20965) adding same css that we have in donate page
…ia#20895) * Fix part of oppia#19849: Show hint to create classroom in navbar * add condition to show hint * update text * update text * fix linter --------- Co-authored-by: Hardik Goyal <[email protected]> Co-authored-by: Akhilesh Kr. <[email protected]>
Removed the Console Error Page
…MacBook at Screen Widths 580px-875px (oppia#20962) * Increasing column width * removing condition rendering * Update exploration-footer.component.html --------- Co-authored-by: Hardik Goyal <[email protected]>
Moved the feature flag to prod.
Console page module removed
…visible on mobile (oppia#20998) * Fix: Ensure 'Create New Topics/Skills' button is always visible on mobile dashboard * bug: removed property to create branch on origin * Fix: Ensure 'Create New Topics/Skills' button is always visible on mobile dashboard --------- Co-authored-by: rishabh.sharma <[email protected]>
) * fix: add character limits to chapter editor for title and description * Fix: Use constants from constants.ts for chapter editor character limits * fix: linting issues * fix: renamed branch to follow naming conventions * fix: renamed branch to follow naming conventions * fix: conflicts resolved * fix: adding comment to fix prettier issues * fix: prettier on whole codebase --------- Co-authored-by: rishabh.sharma <[email protected]>
…ia#20968) * Removed the email dashboard result page * Removed the webpack * Removed module name and removed backend tests * lint fix
…a#20952) * Made changes to migrate blog dashboard page to Angular * Fixed linting issues * Fixed unable to add image/link/video * Added test to fix failing frontend coverage * Removed function used only for testing * Fixed issue with webpack * Removed blog dashboard reference in webpack --------- Co-authored-by: Hardik Goyal <[email protected]>
imchristie
pushed a commit
that referenced
this pull request
Dec 9, 2024
* Managing Issue oppia#20749 * fixed Linter Checks errors * fixed Linter Checks errors #2 * fixed Linter Checks errors #3 * fixed Linter Checks errors #4 * fixed Linter Checks errors #5 * fixed Linter Checks errors #6 --------- Co-authored-by: Martin Šidlík <[email protected]> Co-authored-by: Hardik Goyal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
the cause of the bug was, and which PR introduced it]
Essential Checklist
Please follow the instructions for making a code change.
Testing doc (for PRs with Beam jobs that modify production server data)
Proof that changes are correct
Proof of changes on desktop with slow/throttled network
Proof of changes on mobile phone
Proof of changes in Arabic language
PR Pointers