without screenshots #3

imchristie · 2024-07-10T01:16:22Z

Overview

This PR fixes or fixes part of #[fill_in_number_here].
This PR does the following: [Explain here what your PR does and why]
(For bug-fixing PRs only) The original bug occurred because: [Explain what
the cause of the bug was, and which PR introduced it]

Essential Checklist

Please follow the instructions for making a code change.

I have linked the issue that this PR fixes in the "Development" section of the sidebar.
I have checked the "Files Changed" tab and confirmed that the changes are what I want to make.
I have written tests for my code.
The PR title starts with "Fix #bugnum: " or "Fix part of #bugnum: ...", followed by a short, clear summary of the changes.
I have assigned the correct reviewers to this PR (or will leave a comment with the phrase "@{{reviewer_username}} PTAL" if I can't assign them directly).

Testing doc (for PRs with Beam jobs that modify production server data)

A testing doc has been written: ... (ADD LINK) ...
(To be confirmed by the server admin) All jobs in this PR have been verified on a live server, and the PR is safe to merge.

Proof that changes are correct

Proof of changes on desktop with slow/throttled network

Proof of changes on mobile phone

Proof of changes in Arabic language

PR Pointers

Never force push! If you do, your PR will be closed.
To reply to reviewers, follow these instructions: https://github.com/oppia/oppia/wiki/Make-a-pull-request#step-5-address-review-comments-until-all-reviewers-approve
Some e2e tests are flaky, and can fail for reasons unrelated to your PR. We are working on fixing this, but in the meantime, if you need to restart the tests, please check the "If your build fails" wiki page.
See the Code Owner's wiki page for what code owners will expect.

…function

…-required-details

…teps in GitHub Workflows (oppia#20907) * Allow naming of merge from develop steps in GitHub Workflows * Modify existing test for merge step * Add a linter to require that all GitHub workflow steps be named * Add tests for requiring steps to be named and fix minor details in merge step test * Add names for workflow steps * Fix grammar mistakes in comments --------- Co-authored-by: Sean Lip <[email protected]> Co-authored-by: Akhilesh Kr. <[email protected]>

) * Updates * Updates * Updates * Updates * Updates * Updates * Updates * Updates * Updates * Updates * Updates * Updates * Updates * Updates --------- Co-authored-by: Hardik Goyal <[email protected]> Co-authored-by: Akhilesh Kr. <[email protected]>

* fix question list pagination * add margin and pointer cursor to arrows * modify question list pagination tests for new behavior * run prettier

…raction (oppia#21314) * Fix issue oppia#21243: Made it possible to add solution to code edit interaction * Fix issue oppia#21243: Made it possible to add solution to code edit interaction * Made it possible to add solution to code edit interaction. Also fixed styling issues --------- Co-authored-by: Sean Lip <[email protected]>

…ppia#21340) Added feature flag gate

…hitespace (oppia#21313) use default value when text contains only whitespace

…ppia#21349) * Added enter key press for multiple choice component * Added test for multiple choice enter

* Added new goals-list.html and .ts files * Renamed files to goal-list and imported component into learner-dashboard-page.module * Created complete/incomplete goals sections in goals-tab, passing goalTopics to new goal-list component. * Added story details html * Added keys in en.json and qqq.json * imgUrl for goal-list * Added test cases for imgUrl * Added progress bar (getStoryProgress) * Added test case for getStoryProgress * StoryNode html * Added getNodeLessonUrl in goal-list, returns associated lesson url for each StoryNode. Added test cases. * Added ngCircleProgressModule to learner-dashboard module for goal-list to use. Added button to start StoryNode lesson * getMostRecentCompletedNode and test cases for goal-list * Story node button style for goal-list * handleToggleState for goal-list, displayAllNodes state to toggle subgoals * Notes * Styling fixes * Fixed getMostRecentCompletedNode and added heading style for goals tab * Renamed goal list styles * Linter, goal-list test cases, style fixes * 1. Fixed spacing for add goals button, i81n keys in goals-tab 2. Moved condtional for displaying in-progress & recommended lessons in home-tab 3. Added conditional for background banner to not display in redesign * 1. Background-color 2. Fixed font-size for content-toggle and its position relative to card-display * Styling fixes and remove goal button * Test case for removeGoals * Linter fixes * Linter fix * TypeScript fixes * RTL fix * Fixed karma compoonent/directive issue * Added aria labels to buttons in goals tab * Added aria label to content toggle button * Replaced inline style with classes or ngStyle in goal-list * Replaced ngStyles with classes in goals list * Converted ngStyle to class for add-goals-modal * Fixed karma tests in add goals modal

…ppia#21356) * Remove oppiaml functionality (backend) * Remove oppiaml functionality (frontend) * Update karma and requirements_dev.txt * Fix lint errors. * Drop file that was causing errors in karma test * Fix issues in test setup script

…ppia#21309) * Fixed /explore route redirect * Added error/iframed route * Added the error-iframed page for exp player * Remove the ExplorationEmbedPage class from backend * Removed exploration-player-page-routing.module * Added frontend tests * Removed the old backend tests * Fixed backend tests * Lint fix * fix backend tests * Added logic for handling verison param * Added backend tests * Added Frontend tests and fix backend tests coverage * lint fix * Added logic for X-Frame response header * Mypy fix * Typo fix * lint fix

…tor page and voice artist accent labeling feature from voiceover admin page (oppia#21339) Adds feature flag

* Managing Issue oppia#20749 * fixed Linter Checks errors * fixed Linter Checks errors #2 * fixed Linter Checks errors #3 * fixed Linter Checks errors #4 * fixed Linter Checks errors #5 * fixed Linter Checks errors #6 --------- Co-authored-by: Martin Šidlík <[email protected]> Co-authored-by: Hardik Goyal <[email protected]>

into christie_snapshot2

…4-bit system (oppia#21275) fix: drops the dependency on python during install_node.sh on Docker setup Signed-off-by: gutoslv <[email protected]> Co-authored-by: Sean Lip <[email protected]>

Fixed unresponsive scrolling after side-navbar navigation

…r project ID fetch from env variable (oppia#21237) * Add new platform params * Add email logging for non-prod * Add debug logging for project ID * Revert email platform param changes * Add missed reverts * Location change fixes for email platform params * Fix tests * Fix tests * Fix tests * Fix tests * Fix tests * Add site URL param * Add tests, fix tests * Fix tests * Fix tests * Separate email revert change * Revert missed change * Revert missed change * Fix tests * Fix tests * Update defaults

…ppia#21334) * Fix toolbar for small screens in the translation tab * Made changes as requested by maintainer * Worked on failing Lint checks * Fixed Lint checks

imchristie and others added 30 commits July 9, 2024 17:48

manual copy from christie_snapshot without png files and calling the …

f24e9c6

…function

fix linter

a290dfc

add mobile_golden_screenshots

bd3e2d8

add jest.config.js to RUN_NO_TESTS_ROOT_FILES

69dc1be

restore

4eba2fd

fix conflict

a9fc153

added a few screenshots

78d3c75

fix conflicts

d7b7992

fix comments lint

c683e98

merged develop

69c3b14

deleted all screenshots in logged-out-users

ea2a4da

Merge branch 'develop' into christie_snapshot2

233ac76

add some screenshots

d5d584c

updated failureTrigger when backgroundBanner in mobile mode

8dde0b5

set dumpInLineDiffToConsole as true

a8a1277

updated trigger

29392ad

assertCountEqual

e0f45df

removed screenshots for exploration

a604531

removed Zone.Identifier

65f93d7

updates

5da83fc

Merge branch 'develop' into christie_snapshot2

4a0979d

edited karma.conf.ts

76e86b0

took out the node_modules in combined.spec.ts

a5e6e88

updated blog-editor screenshots

02bbcca

deleted unnecessary files

30d5bb7

added screenshots for blog-editor/create-and-publish-a-blog-post-with…

b64aa40

…-required-details

Merge branch 'develop' into christie_snapshot2

9dfbead

update failureTrigger for desktop to 0.27%

fc521d9

imchristie and others added 30 commits November 28, 2024 03:37

Merge branch 'develop' into christie_snapshot2

7a13175

Fix oppia#20757: Fix question list pagination (oppia#21251)

97dd175

* fix question list pagination * add margin and pointer cursor to arrows * modify question list pagination tests for new behavior * run prettier

Fix oppia#21323 & oppia#21322: Duplicate learner dashboard headers (o…

edb513e

…ppia#21340) Added feature flag gate

Fix oppia#19655: RTE use default value when link text contains only w…

b7a2849

…hitespace (oppia#21313) use default value when text contains only whitespace

Fix oppia#21306: [Feature Request] Multiple choice submit on enter (o…

dfe7436

…ppia#21349) * Added enter key press for multiple choice component * Added test for multiple choice enter

Merge branch 'develop' into christie_snapshot2

32fcd45

Merge branch 'develop' into christie_snapshot2

21b578f

updated donatePage screenshots

f9844ac

deleted helpers/reporter.ts

fb2d964

Adds feature flag to hide voiceover regeneration feature from exp edi…

cac148a

…tor page and voice artist accent labeling feature from voiceover admin page (oppia#21339) Adds feature flag

Merge branch 'develop' into christie_snapshot2

33e3d1d

edited to run on docker

3c8c03d

fixed lint

c12f37a

Merge branch 'christie_snapshot2' of https://github.com/imchristie/oppia

5f2dabc

into christie_snapshot2

Fix oppia#21269 - uses shell instead of python to check if OS has a 6…

51bd8c9

…4-bit system (oppia#21275) fix: drops the dependency on python during install_node.sh on Docker setup Signed-off-by: gutoslv <[email protected]> Co-authored-by: Sean Lip <[email protected]>

Merge branch 'develop' into christie_snapshot2

70ec6b2

Fixed unresponsive scrolling after side-navbar navigation. (oppia#21358)

8bafb15

Fixed unresponsive scrolling after side-navbar navigation

Merge branch 'develop' into christie_snapshot2

1ea72a5

Fix toolbar overflow issue on small screens in the translation tab (o…

60b0544

…ppia#21334) * Fix toolbar for small screens in the translation tab * Made changes as requested by maintainer * Worked on failing Lint checks * Fixed Lint checks

Merge branch 'develop' into christie_snapshot2

e2910d2

Edited clickCreateOneHereLinkOnGetStartedPage in logged-out-user.ts

1b5f0ce

Update logged-out-user.ts with toContain

457f2ec

Update servers.py by adding --detectOpenHandles --forceExit

deb1358

Update Makefile by adding --detectOpenHandles --forceExit

8b51e0f

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

without screenshots #3

without screenshots #3

imchristie commented Jul 10, 2024

without screenshots #3

Are you sure you want to change the base?

without screenshots #3

Conversation

imchristie commented Jul 10, 2024

Overview

Essential Checklist

Testing doc (for PRs with Beam jobs that modify production server data)

Proof that changes are correct

Proof of changes on desktop with slow/throttled network

Proof of changes on mobile phone

Proof of changes in Arabic language

PR Pointers