Skip to content

Commit

Permalink
Merge pull request #56 from prasoon0909/feat/pr-review-48-54
Browse files Browse the repository at this point in the history
Feat/pr review 48 54
  • Loading branch information
imagekitio authored Aug 23, 2023
2 parents 1499945 + 9101ca2 commit 755bf0d
Show file tree
Hide file tree
Showing 5 changed files with 30 additions and 22 deletions.
2 changes: 1 addition & 1 deletion DEVELOPMENT.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,5 +16,5 @@ bundle exec rake

**3. To build gem**
```shell
gem build imagekit.gemspec
gem build imagekitio.gemspec
```
24 changes: 12 additions & 12 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,18 +13,18 @@ Ruby on Rails gem for [ImageKit](https://imagekit.io/) implements the new APIs a
ImageKit is complete media storage, optimization, and transformation solution that comes with an [image and video CDN](https://imagekit.io/features/imagekit-infrastructure). It can be integrated with your existing infrastructure - storage like AWS S3, web servers, your CDN, and custom domain names, allowing you to deliver optimized images in minutes with minimal code changes.

Table of contents -
* [Installation](#Installation)
* [Initialization](#Initialization)
- [CarrierWave](#Carrierwave)
- [ActiveStorage](#activeStorage)
* [URL Generation](#URL-generation)
* [File Upload](#File-Upload)
* [File Management](#File-Management)
* [Utility Functions](#Utility-functions)
* [Sample applications](#Sample-Application)
* [Upgrade to 2.x](#upgrade-to-2.x)
* [Support](#Support)
* [Links](#Links)
* [Installation](#installation)
* [Initialization](#initialization)
- [CarrierWave](#carrierwave)
- [ActiveStorage](#activestorage)
* [URL Generation](#url-generation)
* [File Upload](#file-upload)
* [File Management](#file-management)
* [Utility Functions](#utility-functions)
* [Sample applications](#sample-application)
* [Upgrade to 2.x](#upgrade-to-2x)
* [Support](#support)
* [Links](#links)


# Quick start guide
Expand Down
11 changes: 5 additions & 6 deletions imagekitio.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,10 @@ Gem::Specification.new do |spec|

spec.files = Dir["{app,config,db,lib}/**/*", "MIT-LICENSE", "Rakefile", "README.md"]

# spec.add_dependency "rails", "~> 5.2.0", ">= 5.2.0"
spec.add_dependency 'carrierwave', '>= 0.7', '< 2.2'
spec.add_dependency 'rest-client', '~> 2.1', ">=2.1"
spec.add_dependency 'addressable', '~> 2.8'
spec.add_dependency 'activestorage', '>= 5.2.0'
spec.add_dependency 'multipart-post', '>= 2.1.0'
spec.add_dependency "addressable", "~> 2.8"
spec.add_dependency "multipart-post", ">= 2.1.0"
spec.add_dependency "rest-client", "~> 2.1", ">=2.1"
spec.add_development_dependency "activestorage", ">= 5.2.0"
spec.add_development_dependency "carrierwave", ">= 0.7", "<= 2.2.1"
spec.add_development_dependency "rails", "~> 5.2.0", ">= 5.2.0"
end
9 changes: 7 additions & 2 deletions lib/active_storage/active_storage.rb
Original file line number Diff line number Diff line change
@@ -1,2 +1,7 @@
require_relative './service/ik_file'
require_relative './service/image_kit_io_service'
begin
require 'active_storage'
rescue LoadError
puts "Add gem 'activestorage' to use this service"
end
require_relative './service/ik_file'
require_relative './service/image_kit_io_service'
6 changes: 5 additions & 1 deletion lib/carrierwave/carrierwave.rb
Original file line number Diff line number Diff line change
@@ -1,4 +1,8 @@
require 'carrierwave'
begin
require 'carrierwave'
rescue LoadError
puts "Add gem 'carrierwave' to use this service"
end
require_relative './storage/imagekit_store'
require_relative './storage/ik_file'
require_relative './support/uri_filename'
Expand Down

0 comments on commit 755bf0d

Please sign in to comment.