Skip to content

Commit

Permalink
application: do not try to install imagej-launcher-*.jar
Browse files Browse the repository at this point in the history
Currently, mvn -Dapp fails with something like:

    [INFO] --- maven-assembly-plugin:3.2.0:single (make-assembly) @ imagej ---
    [INFO] Reading assembly descriptor: src/main/assembly/zip.xml
    [WARNING] The assembly descriptor contains a *nix-specific root-relative reference (starting with slash). This is not portable and might fail on Windows: /Contents/Resources/
    [WARNING] The assembly descriptor contains a *nix-specific root-relative reference (starting with slash). This is not portable and might fail on Windows: /images/
    [WARNING] The assembly descriptor contains a *nix-specific root-relative reference (starting with slash). This is not portable and might fail on Windows: /images/
    [INFO] ------------------------------------------------------------------------
    [INFO] BUILD FAILURE
    [INFO] ------------------------------------------------------------------------
    [INFO] Total time:  15.826 s
    [INFO] Finished at: 2021-09-10T13:43:20+02:00
    [INFO] ------------------------------------------------------------------------
    [ERROR] Failed to execute goal org.apache.maven.plugins:maven-assembly-plugin:3.2.0:single (make-assembly) on project imagej: Failed to create assembly: Error adding file to archive: /home/grimler/imagej2/src/imagej2-imagej-2.2.0/target/imagej-launcher-6.0.1.jar -> [Help 1]
    [ERROR]
    [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
    [ERROR] Re-run Maven using the -X switch to enable full debug logging.
    [ERROR]
    [ERROR] For more information about the errors and possible solutions, please read the following articles:
    [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException

The same error (I think) was fixed for pom.xml in c3562b1 ("Fix
imagej-launcher dependency").

Fixes #293.

Signed-off-by: Curtis Rueden <[email protected]>
  • Loading branch information
Grimler91 authored and ctrueden committed Sep 10, 2021
1 parent ee1a3ca commit 4bc751d
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 5 deletions.
4 changes: 4 additions & 0 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,10 @@
<url>https://imagej.net/people/tferr</url>
<properties><id>tferr</id></properties>
</contributor>
<contributor>
<name>Henrik Grimler</name>
<properties><id>Grimler91</id></properties>
</contributor>
<contributor>
<name>Aivar Grislis</name>
<url>https://imagej.net/people/grislis</url>
Expand Down
5 changes: 0 additions & 5 deletions src/main/assembly/application.xml
Original file line number Diff line number Diff line change
Expand Up @@ -84,11 +84,6 @@
</file>

<!-- Include the ImageJ launcher executables in appropriate locations. -->
<file>
<source>target/imagej-launcher-${imagej-launcher.version}.jar</source>
<outputDirectory>jars/</outputDirectory>
<destName>imagej-launcher-${imagej-launcher.version}.jar</destName>
</file>
<file>
<source>target/imagej-launcher-linux64</source>
<destName>ImageJ-linux64</destName>
Expand Down

0 comments on commit 4bc751d

Please sign in to comment.