Real transform

[bnorthan]

This commit applies a realtransform to an input image.

Round 2

The Op is now called DefaultTransformView and wraps Views.transformReal. And the transforms are more "intuitive" (trans.scale(0.5) makes the image smaller. Use case is below

AffineTransform2D transform = new AffineTransform2D();

transform.translate(-image.dimension(0)/2,-image.dimension(0)/2);
transform.rotate(1);
transform.scale(0.5);
transform.translate(image.dimension(0)/2,image.dimension(0)/2);

RandomAccessibleInterval<UnsignedByteType> actualOutput=ops.transform().realTransform(image, transform);

[awalter17]

This should be ops().run(Ops.Transform.RealTransform.class, in, transform). That way, in the future, someone could write an op which is a specialized version of this and it could also be matched.

Please change this for all your other realTransform(...) namespace methods as well.

[awalter17]

This doesn't need to be explicitly set to null. You can just have private Interval outputInterval.

[awalter17]

This can just be private InterpolatorFactory<T, RandomAccessible<T>> interpolator;. There's no need for the = null.

[awalter17]

This isn't used (unless I'm missing something?). On line 97 you call Views.extendZero(input), so zero padding is always the out of bounds strategy. Do you want the user to be able to specify their own out of bounds strategy?

[awalter17]

Here you should use ops().run(net.imagej.ops.transform.realTransform.DefaultTransformView.class, image, transform);, to ensure that DefaultTransformView is always tested.

[awalter17]

@bnorthan I've rebased this branch over master, updated the license header, and fixed a few whitespace issues. I've also noted a few minor changes that need to be fixed, but after that this should be good to merge.

Thank you for all your work on this! 😺

[bnorthan]

@awalter17 I just did all the changes you requested. Please let me know if there is anything else. Thanks.

[imagejan]

@ctrueden @bnorthan are there any plans to merge this one soon? Or is it on hold until scijava-ops are out?
I'm asking because I'd like to use some of this functionality, but I can also fall back to using ImgLib2 directly.

[bnorthan]

Hi @imagejan

It's been a while... I made some changes to this over a year ago but it looks like it slipped through the cracks after that. I'm not sure what the best approach is for changes to imagej-ops/scijava-ops right now. I've only made a couple of small changes in the last few months, and just flagged @gselzer so he can make the same change in scijava-ops.

[ctrueden]

@gselzer How much effort do you think it would be to port this to scijava-ops soon? I'd rather not add more new features to imagej-ops at this juncture—but I really want this function in the new ops. 😄

[gselzer]

@ctrueden I only have time to quickly glance over this, but we can probably add all this functionality with a couple of OpFields. I will add it to the TODO list

[imagejan]

@gselzer @ctrueden is anything like this usable in the new scijava-ops (https://github.com/scijava/incubator) yet?

It would be a good argument for me to get started exploring your recent work of overhauling the ops framework 🙂

[gselzer]

@imagejan scijava/incubator#36 😉