Skip to content

Conversation

@Shnatsel
Copy link
Member

@Shnatsel Shnatsel commented Nov 10, 2025

We gave 0.25.8 a couple of months to stew and it didn't really need any urgent fixes. So let's ship one last minor release in 0.25.x series and then start merging breaking changes to main, as previously discussed.

Blocked on #2641

I also want to get GIF ICC and XMP metadata merged before this release, so marking this as draft until that's done. That depends on image-rs/image-gif#222 and #2644

@fintelia
Copy link
Contributor

fintelia commented Nov 12, 2025

It would be good to make sure that any items we want to mark as #[deprecated] get included with this release. At a minimum, I think that's DynamicImage::resize (in favor of resize_proportional)

@197g
Copy link
Member

197g commented Nov 12, 2025

I'm not sure how sensible it is to mark those deprecated without having a replacement within the same compatible version release train ready. What we'd really want is a one-time signal on upgrading to the next major version, to check for those uses that accidentally still work but the deprecation is instead a constant hassle for everyone not upgrade–which is somehow the opposite effect of the intention.

@Shnatsel
Copy link
Member Author

resize_proportional isn't implemented yet. I'd rather not show deprecation warnings when people can't actually fix them.

And I'd really like to change the signature of all resize_* functions in the next semver-breaking release anyway, so fixing it today wouldn't even avoid breaking changes when migrating to 1.0 or whatever we call it.

Figuring out the shape of the API changes for the next breaking release is going to take a while, so I'd rather not block shipping v0.25.9 on that.

@Shnatsel Shnatsel marked this pull request as ready for review November 12, 2025 22:57
@fintelia
Copy link
Contributor

I'm also OK with shipping 0.25.9 now and then doing a 0.25.10 release later once we have a complete list of all deprecations we want to make. It is a little extra effort because we'd need a 0.25.x series branch to make the release off of, but not a big deal.

We can discuss the resize methods more in #2645

@fintelia
Copy link
Contributor

On the topic of starting to merge breaking changes ahead of the 1.0 release: I think now is a good time to start the process, though I personally don't have time at the moment to drive the effort so other folks will have to take the lead.

@197g
Copy link
Member

197g commented Nov 13, 2025

That sounds like a good plan to me, too. So:

  • Release 0.25.9
  • Keep a version-0.25 branch around without breaking changes
  • Prepare 1.0 (I'm much less reluctant to go with that as a new version now that color spaces are in place, the Pixel and GenericImage clarifications, and knowing from several sketches that different buffers are possible to fit in).
  • Release 0.25.10 with deprecation that points to a 1 migration once in place.

Sure, can drive that until over the new year.

@Shnatsel
Copy link
Member Author

Sounds like v0.25.9 is good to go?

@197g 197g merged commit 5ceb6af into image-rs:main Nov 15, 2025
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants