Fixed the problem of Animated PNGs being decoded incorrectly #2327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed the update range of dispose_op for Previous and Background in APngDecoder, which was applied to the entire image, to now be within the update range of the previous frame.
fintelia
reviewed
Sep 14, 2024
higumachan
force-pushed
the
fix/apng-decoder
branch
from
be587fd to
e14b4ac
Compare
|
Thank you for reviewing.
Hmm, I’ve removed the data for now, but I don’t have a suitable replacement on hand, so I can’t add the test. What should I do? |
|
If anyone wants to either manually construct a test image or track down a suitably licensed one, that would be appreciated. But I don't think it needs to block landing this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: #2265
Fixed the update range of dispose_op for Previous and Background in APngDecoder, which was applied to the entire image, to now be within the update range of the previous frame.
I referred to the following URL https://wiki.mozilla.org/APNG_Specification
I have checked in my environment and it works fine for the image in #2265.
The following is the data saved as an image of the frame.
frames.zip