Handle non-fatal error dav1d::Error::Again #2043
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue location:
src/codecs/avif/decoder.rs
line 43 and 50Currently, when
send_data
is called, its non-fatal error variantAgain
is treated as a fatal one, where this may be treated bysend_pending_data
, as mentioned by the dav1d-rs docs (dav1d-rs docs fail to build so i used this screenshot from my local build).#2023 addresses this issue as well, but does not handle the case of Alpha channels and only calls
send_pending_data
once.I license past and future contributions under the dual MIT/Apache-2.0 license,
allowing licensees to choose either at their option.