Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle non-fatal error dav1d::Error::Again #2043

Merged
merged 4 commits into from
Nov 4, 2023
Merged

Handle non-fatal error dav1d::Error::Again #2043

merged 4 commits into from
Nov 4, 2023

Conversation

FlareFlo
Copy link
Contributor

@FlareFlo FlareFlo commented Nov 1, 2023

Issue location:
src/codecs/avif/decoder.rs line 43 and 50

Currently, when send_data is called, its non-fatal error variant Again is treated as a fatal one, where this may be treated by send_pending_data, as mentioned by the dav1d-rs docs (dav1d-rs docs fail to build so i used this screenshot from my local build).

#2023 addresses this issue as well, but does not handle the case of Alpha channels and only calls send_pending_data once.

I license past and future contributions under the dual MIT/Apache-2.0 license,
allowing licensees to choose either at their option.

@fintelia fintelia merged commit eb05a39 into image-rs:master Nov 4, 2023
35 checks passed
@fintelia
Copy link
Contributor

fintelia commented Nov 4, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants