Overhaul Pixel methods on ImageBuffer
and GenericImage
/GenericImageView
traits
#1920
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1853 for background
Best viewed commit by commit. Most of the changes are in the first commit.
This PR adds
Option
-returning methods to the main image traits. Duplicate methods thatImageBuffer
implemented were removed.I migrated functions that used the old methods like
get_pixel
internally to the newerOption
methods where applicable so they could eventually be phased out. Where possible, I kept the old behavior by usingIndex
access onImageBuffer
s. Since this is a breaking change, I also removed the deprecated functions from the traits.pixel[_unchecked]
to GenericImageViewpixel_mut[_unchecked]
to GenericImageget_pixel_mut
,blend_pixel
from GenericImageget_pixel[_checked]
,get_pixel_mut[_checked]
from ImageBufferget_pixel[_mut]
to Index, IndexMutpixel_i64
to GenericImageView,pixel_mut_i64
to GenericImage