Check if resizing to the same size #1763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm not entirely sure why this fails, but no other tests use the manifest directory
fintelia
reviewed
Jul 24, 2022
Co-authored-by: Jonathan Behrens <[email protected]>
fintelia
reviewed
Jul 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1738 by checking if resizing is to the same size the image already is.
there's a lot more optimizations that could be made here, such as detecting integer scaling or a Pillow-style "reduce gap" method (maybe as an additional filter mode, since it only makes sense for bilinear). However from #1718 it looks like you may be planning a refactor of the backing data structures for pixels?