Faster YUV -> RGBA conversion #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…codepath. RGB was already using it, so this is just a port from RGBA.
|
Writing a quickcheck-like test was a hassle because I didn't know how to properly populate |
This was referenced Dec 19, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply the two-pixels-at-once optimization for YUV conversion to RGBA codepath. RGB was already using it, so this is just a port of the same algorithm to RGBA.
Most of the code was written by @okaneco and posted in a comment on #13, I've just wired up the function they shared on godbolt.
I'm seeing a 7% end-to-end performance improvement on the sample from #119. With YUV->RGBA conversion accounting for 16% of the time, the function must have gotten roughly twice faster.