New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Read Byte as u8, SignedByte as i8 #236

Draft

weiji14 wants to merge 2 commits into image-rs:master from weiji14:byte_u8_sbyte_i8

Contributor

weiji14 commented Jul 22, 2024 •

edited

Loading

Previously, Byte values were read incorrectly as u32 instead of u8, and SignedShort values were read incorrectly as i32 instead of i8.

This PR does the following:

Correctly cast Type::BYTE as u8 values, and support casting Byte to other unsigned types via into_u16, into_u32, into_u64, into_u16_vec, into_u32_vec, and into_u64_vec methods.
Correctly cast Type::SBYTE as i8 values

Similar to #235, resolves some inconsistencies raised in #204.

weiji14 added 2 commits

July 22, 2024 19:22


          Cast Byte to u8 instead of u32

9fee8f6

Also handle casting of Byte (u8) into other unsigned types.


          Cast SignedByte to i8 instead of i32

dd783c3

Also handle casting of SignedByte (i8) into other signed types.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet