Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lazy parse sBIT #556

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Lazy parse sBIT #556

wants to merge 3 commits into from

Conversation

kornelski
Copy link
Contributor

Alternative to 2949036 (#554)

Needs image-rs/fdeflate#43

I like the previous solution with warnings: Vec<Error>, since it's easy to implement, uniformly handles all ancillary chunks, keeps Info small, and is lossless.

Here's an alternative solution that keeps one parse error per chunk.

In either case, I think it's better to keep the errors than to discard them. It seems weird to have all these parsers and error enums that just get discarded. That's dead code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant