Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small refactoring of paeth filter logic #544

Merged
merged 2 commits into from
Dec 6, 2024

Conversation

fintelia
Copy link
Contributor

@fintelia fintelia commented Dec 5, 2024

Better naming for each of the paeth_filter methods:

  • filter_paeth: Straightforward implementation as described in the PNG spec
  • filter_paeth_stbi: Version from STB Image
  • filter_paeth_stbi_i16: Same as above, but uses i16's as input/output
  • filter_paeth_fpnge: Version from FPNGE

Also fixes an edge case where enabling the "unstable" feature on non-x86_64 architectures would skip filtering, and adjusted the code structure to make similar issues less likely in the future.

@fintelia fintelia merged commit fb660c2 into image-rs:master Dec 6, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants