Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nicer ignore of parse errors in sBIT #535

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Nicer ignore of parse errors in sBIT #535

wants to merge 1 commit into from

Conversation

kornelski
Copy link
Contributor

No description provided.

@fintelia
Copy link
Contributor

It would be nice to align the style with parse_cicp, parse_mdcv, and parse_clli. And ideally the rest of the optional metadata chunks as well.

@kornelski
Copy link
Contributor Author

Oh, that would be even bigger churn. I'd rather not.

If I were going to touch them, I'd change them all to the style of sBIT, because having parsing code that can't use Result is too cumbersome, and having extra inner helper function is unnecessary if the failure can be ignored in parse_chunk.

@kornelski
Copy link
Contributor Author

I've considered changing error handling for all ancillary chunks, but if we haven't had reports of unnecessary failures caused by them, then maybe they're not too broken in the wild, and it's okay to keep stricter checks.

@fintelia
Copy link
Contributor

Switching the other ancillary chunks is tracked in #525.

We don't have to switch everything in one PR. But I would like to decide on one approach to ignore errors from chunks and then make sure all changes move us towards that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants