-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for parsing cICP
chunks.
#529
Conversation
Seems reasonable.
It is described in section 8.3 of the 7/24 version of ITU-T-H.273 under the name "VideoFullRangeFlag". The values don't seem to have names and are just listed as 0 and 1. I think it might be worth encoding it just as a |
This commit is needed for parity with the existing PNG decoder in Blink / Chromium - see https://crbug.com/376758571.
d84b526
to
e88d94c
Compare
Ack.
Thanks for the feedback. Done (changed to |
This CL patches the `png` crate in a way that corresponds to the following upstream PRs: * image-rs/image-png#526 - baseline to make subsequent patches easier to apply * image-rs/image-png#528 - `mDCv` and `cLLI` * image-rs/image-png#529 - `cICP` This CL is a prerequisite for rolling Skia beyond http://review.skia.org/917216 Bug: chromium:376758571 Bug: chromium:376550658 Change-Id: I5a70fccd71ae4295b62f7291a5fd3809f0d53860 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5999738 Commit-Queue: Łukasz Anforowicz <[email protected]> Reviewed-by: Adrian Taylor <[email protected]> Cr-Commit-Position: refs/heads/main@{#1385066}
This CL propagates the data from the `cICP` chunk into `SkEncodedInfo::ICCProfile`. Dependencies: * This CL unblocks enabling the `PNGTests.cicp` test in the Chromium CL at https://crrev.com/c/6013356. * This CL depends on the new `SkColorSpace::MakeCICP` API that was recently added in https://crrev.com/c/5999738. This CL patches the `png` crate in a way that corresponds to the following upstream PRs (rolling this CL into Chromium depends on https://crrev.com/c/5999738 which included the same patches): * image-rs/image-png#526 - baseline to make subsequent patches easier to apply * image-rs/image-png#528 - `mDCv` and `cLLI` * image-rs/image-png#529 - `cICP` Bug: chromium:376758571 Change-Id: I1e550b1eba4d629ff4337d85daa5656ac03f3a5a Reviewed-on: https://skia-review.googlesource.com/c/skia/+/917216 Commit-Queue: Łukasz Anforowicz <[email protected]> Reviewed-by: Daniel Dilan <[email protected]>
This commit is needed for parity with the existing PNG decoder in Blink / Chromium - see https://crbug.com/376758571.
I think that we should opaquely return
u8
forcolor_primaries
andtransfer_function
. Being opaque will help with extensibility (in case ITU-T-H.273 gets augmented in the future with other table entries / configurations).I am less sure about the other 2 fields:
matrix_coefficients
asu8
and return it even though the parser rejects anything other than 0 (same asblink::PNGImageDecoder
in Chromium - see here).video_full_range_flag
as anenum
.