Upgrade bitflags to 2.0. #516
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeroicKatora
reviewed
Oct 1, 2024
There was a problem hiding this comment.
The new version of bitflags no longer generates from_bits_unchecked. I think the next release is planned to be a breaking one anyways, just qualifying that there technically is an interface difference.
|
Mmm, yes, that's a good point. |
HeroicKatora
approved these changes
Oct 1, 2024
|
Note that there is a similar existing PR: #400 |
|
any chance we can get this or #400 merged? I agree with this comment, #400 (comment) I personally find it easier to deal with a few releases each with small breaking changes that one release which has lots of breaking changes as you can fix them one at a time instead of all in one go. This makes resulting downstream changes/upgrades easier to review for people/teams using this crate. |
Merged
|
Closing in favor of #400 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.