New PNG inputs for benchmarking non-compressed, non-filtered data. #420
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PTAL?
The new test images are somewhat artificial, but they help to see the performance of the bulk of the PNG decoding code. Runtime overhead of this code is relatively small when compared to the overhead of decompression (mostly in the
fdeflate
crate) and unfiltering (insrc/filter.rs
), but performance of this code is still important (e.g. as discussed in another discussion thread, optimizing this code can yield 10+% of gains for a more realistic test corpus). And I think that these new test images will be a useful tool for evaluating performance of this code (which may be more difficult to confidently measure using other test inputs).I am adding 2 separate images, because I think that: