Change hardcoded table sizes into const-generic params.
#49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kornelski
approved these changes
Jan 13, 2025
fintelia
reviewed
Jan 14, 2025
| @@ -610,6 +618,20 @@ impl CompressedBlock { | |||
| mut output_index: usize, | |||
| queued_output: &mut Option<QueuedOutput>, | |||
| ) -> Result<(CompressedBlockStatus, usize), DecompressionError> { | |||
| // `litlen_table_mask` (and `dist_table_mask`) calculation assumes that `LITLEN_TABLE_SIZE` | |||
| // (or `DIST_TABLE_SIZE`) is a power of two. | |||
| assert!(LITLEN_TABLE_SIZE.count_ones() == 1); | |||
There was a problem hiding this comment.
Doesn't make a huge difference, but there's actually a is_power_of_two method.
There was a problem hiding this comment.
and this could be in const {} to check at compile time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PTAL?