Moving functions into impl CompressedBlock
#47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change is desirable for 2 reasons: * Less important: this keeps `pub fn` together, at the top. * More important: this places `fn build_tables` and `fn read_compressed` at the end of the `impl` block, making it easier to move them into `impl CompressedBlock` (without moving them within the source file).
anforowicz
changed the title
impl CompressedBlock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is motivated by the investigation from #45. At this point I am fairly sure that we will need to support different table sizes. And these 3 commits prepare for this in a fairly straighforward/non-controversial way.
PS. I also have a potential follow-up at https://github.com/anforowicz/fdeflate/tree/const-generic-table-sizes3, but I need to think more about whether making
read_compresseda free function is justified. If we support 512/128 tables, then using the fixed tables directly seems like a "free" optimization. OTOH, the cost of copying fixed tables intoCompressedBlockis probably not that high (i.e. the benefit is not that high).