Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Support array sample format #51

Merged
merged 4 commits into from
Apr 8, 2024
Merged

Conversation

chubei-urus
Copy link
Contributor

A floating point image that was saved from PhotoShop sets "SampleFormat" to [3, 3, 3].

A floating point image that was saved from PhotoShop sets "SampleFormat" to [3, 3, 3].
@chubei-urus chubei-urus closed this Apr 2, 2024
@chubei-urus chubei-urus deleted the patch-2 branch April 2, 2024 03:28
@chubei-urus chubei-urus restored the patch-2 branch April 2, 2024 03:28
@chubei-urus chubei-urus reopened this Apr 2, 2024
@chubei-urus
Copy link
Contributor Author

Hi @targos, I'm wondering if you'd accept this fix? And if so, what else needs to be done, in terms of test, documentation, etc.?

@targos
Copy link
Member

targos commented Apr 2, 2024

Thanks for the contribution. Please add an example file (small if possible) to the img folder, and add a test case at the end of this array: https://github.com/image-js/tiff/blob/main/src/__tests__/decode.test.ts#L19

@chubei-urus chubei-urus marked this pull request as ready for review April 2, 2024 10:27
@chubei-urus
Copy link
Contributor Author

I added a 2x2 image, but it's still 19KB.

@targos targos merged commit 42d778b into image-js:main Apr 8, 2024
7 checks passed
@chubei-urus chubei-urus deleted the patch-2 branch April 8, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants