Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: #2631, #2282 translate callback to Korean and place it under lo… #2641

Merged
merged 4 commits into from
Mar 9, 2024

Conversation

Nickolodeon98
Copy link
Contributor

…calization/ko/callback

Translate callback pattern README to Korean and place it under localization/ko/callback

Pull request description

  • Package 'callback' is created under localization/ko with README.md and etc/callback.png inside.

For detailed contributing instructions see https://github.com/iluwatar/java-design-patterns/wiki/01.-How-to-contribute

Copy link

sonarqubecloud bot commented Nov 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link

stale bot commented Dec 1, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the status: stale issues and pull requests that have not had recent interaction label Dec 1, 2023
Copy link

stale bot commented Jan 15, 2024

Closed due to inactivity. Thank you for your contributions.

@stale stale bot closed this Jan 15, 2024
@iluwatar iluwatar reopened this Mar 9, 2024
@stale stale bot removed the status: stale issues and pull requests that have not had recent interaction label Mar 9, 2024
@iluwatar iluwatar merged commit 09b9ee2 into iluwatar:master Mar 9, 2024
2 checks passed
@iluwatar
Copy link
Owner

iluwatar commented Mar 9, 2024

Looks good! Thank you for the contribution 🎉

@all-contributors please add @Nickolodeon98 for translation

Copy link
Contributor

@iluwatar

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

I've put up a pull request to add @Nickolodeon98! 🎉

Copy link

sonarqubecloud bot commented Mar 9, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants