Add is best model to training servicer #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thodkatz
force-pushed
the
add-is-best-model-to-training-servicer
branch
3 times, most recently
from
b60fb5f to
90b4a5e
Compare
thodkatz
force-pushed
the
add-is-best-model-to-training-servicer
branch
from
90b4a5e to
811ddd3
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #229 +/- ##
==========================================
- Coverage 64.60% 62.83% -1.78%
==========================================
Files 40 47 +7
Lines 2195 2876 +681
==========================================
+ Hits 1418 1807 +389
- Misses 777 1069 +292 ☔ View full report in Codecov by Sentry. |
thodkatz
force-pushed
the
add-is-best-model-to-training-servicer
branch
2 times, most recently
from
b10d4f9 to
14f81af
Compare
thodkatz
force-pushed
the
add-is-best-model-to-training-servicer
branch
from
14f81af to
3d62b13
Compare
Whenever we have a new model, a stream will yield a response. The client can utilize this to perform certain actions e.g. ilastik to propagateDirty any predictions performed on previous models.
thodkatz
force-pushed
the
add-is-best-model-to-training-servicer
branch
from
3d62b13 to
c5b8bf6
Compare
The response of the best model stream will return an id. The id is
increased by one, each time we have a new model. A client can identify
if an action has been performed by an outdated model based on the id. If
the current is greater, then a new best model exists.
thodkatz
force-pushed
the
add-is-best-model-to-training-servicer
branch
from
c5b8bf6 to
44bc634
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It builds upon #228 .
Whenever we have a new best model, the
IsBestModelstream will yield a response. The client can utilize this to perform certain actions e.g. ilastik topropagateDirtyany predictions performed on previous models.