Python wrapper script #62
Conversation
m-novikov
requested review from
Tomaz-Vieira and
m-novikov
and removed request for
Tomaz-Vieira
| @@ -24,13 +24,17 @@ def get_queryset(self): | |||
| return super().get_queryset().select_related("file") | |||
|
|
|||
|
|
|||
| PROJECT_WORKFLOWS = ("Pixel Classification", "Object Classification") | |||
There was a problem hiding this comment.
I think here snake_case should be used. While I know that in ilastik workflow name is used in this format and relied upon, I think can be easily misinterpreted as a human-readable string and changed. Related ilastik/ilastik#2219
There was a problem hiding this comment.
See question/discussion in related.
| def main(): | ||
| os.environ["PATH"] = os.pathsep.join( | ||
| [ | ||
| os.path.expanduser("~/miniconda3/envs/ildev/bin"), |
There was a problem hiding this comment.
Should this be configured somehow?
There was a problem hiding this comment.
This was copied verbatim from the existing script, but yes, I also don't like it.
Anyway, it's probably better not to copy scripts with the payload and config every time someone submits a job. We should embed this in a deployed environment somehow (which will probably include the whole Python + deps).
Yes, it worked at the time I've submitted this PR. However, I think it should be more configurable, and we also need to rebase this on top of #65, so it's probably better to scrap this altogether. |
|
Closed because this PR contains a lot of auth code, but HBP is migrating to FURMS (Fenix User and Resource Management Service). |
No description provided.