Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #319: upload docker images to ghcr.io as well #320

Merged
merged 16 commits into from
Apr 10, 2024

Conversation

KEINOS
Copy link
Contributor

@KEINOS KEINOS commented Apr 10, 2024

This PR will fix the issue #319.

According to my understanding, this should upload the docker images to GitHub Container Registry as well. 🤞

If it fails, please check the permissions/scopes of the personal access token, "GO_RELEASER_TOKEN".
It may require extra scope to login.

deepsource-autofix bot and others added 16 commits October 17, 2023 08:34
Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com>
Bumps [actions/setup-go](https://github.com/actions/setup-go) from 4 to 5.
- [Release notes](https://github.com/actions/setup-go/releases)
- [Commits](actions/setup-go@v4...v5)

---
updated-dependencies:
- dependency-name: actions/setup-go
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
…/actions/setup-go-5

Bump actions/setup-go from 4 to 5
fix: Poor file permissions used when creating a file or using os.Chmod GSC-G302
Bumps [ts-graphviz/setup-graphviz](https://github.com/ts-graphviz/setup-graphviz) from 1 to 2.
- [Release notes](https://github.com/ts-graphviz/setup-graphviz/releases)
- [Commits](ts-graphviz/setup-graphviz@v1...v2)

---
updated-dependencies:
- dependency-name: ts-graphviz/setup-graphviz
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* update: fix page number

* fix: book page number

* update: add original sample code
@ikawaha
Copy link
Owner

ikawaha commented Apr 10, 2024

Thank you for your pull request! Really appreciate you tackling an issue that had been sitting idle for a while 🙏 . I will try to adjust the token's permissions.

@ikawaha ikawaha merged commit 2ef2717 into ikawaha:develop Apr 10, 2024
7 checks passed
@KEINOS KEINOS deleted the fix-319_push-docker-image-to-ghcr-io branch April 11, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants