Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark theme feature added to Notes App, issue #3 #17

Closed
wants to merge 6 commits into from

Conversation

Karanagarwal12
Copy link

Added the dark mode feature as mentioned in issue #3.
Please have a look if it is good or not

lightModeNotes
darkModeNotes

@AkhileshJyotishi
Copy link
Contributor

AkhileshJyotishi commented Mar 16, 2024

@Karanagarwal12

You resolving all the issues in the same branch.

You should create different branch for different issues.

For each different issue you should do -

git checkout main 

git checkout -b <branch-name>

branch name can be feature-<branch-name> or bug-<branch-name>

depending upon what issue you are tackling

Your work looks fine.Just make a different branch and create another pull request .

Thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants