Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a cmake config to help find image resources #693

Merged
merged 9 commits into from
Nov 2, 2023

Conversation

matthewroberthenderson
Copy link
Contributor

@matthewroberthenderson matthewroberthenderson commented Oct 31, 2023

When debugging an an example app after first configuring the project the image paths cannot be located. Adding a simple in file could also be used for other relative project paths.

close #694

@ihhub
Copy link
Owner

ihhub commented Nov 1, 2023

Hi @matthewroberthenderson , the provided by you solution fails on Linux (see this).

Let's understand the root of the problem: I assume that images are not being copied together with source files during CMake configuration. Therefore, I suggest to add file copying part in CMake files and use relative path for images without modifying source files.

@matthewroberthenderson
Copy link
Contributor Author

@ihhub Yep that makes more sense to me thanks for this. I'll update my PR.

@ihhub ihhub added improvement Upgrade existing feature cmake All related tasks to CMake files labels Nov 1, 2023
@ihhub ihhub added this to the 1.0 milestone Nov 1, 2023
@ihhub ihhub merged commit fef0910 into ihhub:master Nov 2, 2023
5 checks passed
@ihhub
Copy link
Owner

ihhub commented Nov 2, 2023

@matthewroberthenderson , thank you very much for your contribution to the project!

@matthewroberthenderson
Copy link
Contributor Author

@matthewroberthenderson , thank you very much for your contribution to the project!

Very happy to. Really love this project, thanks for putting it out there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmake All related tasks to CMake files improvement Upgrade existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to debug example projects as image paths are in a different location
2 participants