Change randomValue function to provide reaching of maximum value. #565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ihhub
requested changes
Dec 6, 2019
| @@ -207,8 +207,8 @@ namespace image_function_cuda | |||
| const std::vector < uint8_t > intensity = intensityArray( 2 ); | |||
| PenguinV_Image::Image input = uniformImage( intensity[0], 0, 0, reference ); | |||
|
|
|||
| const bool horizontalFlip = (randomValue<uint32_t>( 0, 2 ) == 0); | |||
| const bool verticalFlip = (randomValue<uint32_t>( 0, 2 ) == 0); | |||
| const bool horizontalFlip = ( randomValue<uint32_t>( 0, 1 ) == 0 ); | |||
There was a problem hiding this comment.
Let's create randomBoolValue() function instead. No harm to do this but it makes code easier to read.
There was a problem hiding this comment.
For this function we could use rand() directly, no need to call randomValue<> function
| @@ -1935,8 +1935,8 @@ namespace Function_Template | |||
| { | |||
| const std::vector < uint8_t > intensity = intensityArray( 2 ); | |||
| PenguinV_Image::Image image = uniformImage( intensity[0] ); | |||
| const uint32_t x = randomValue<uint32_t>( 0, image.width() ); | |||
| const uint32_t y = randomValue<uint32_t>( 0, image.height() ); | |||
| const uint32_t x = randomValue<uint32_t>( 0, image.width() - 1 ); | |||
There was a problem hiding this comment.
I'm not sure that this format is good as another developer would definitely forget to add - 1. What's your opinion?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #251
Hey, @ihhub look, please.
You've said in the description that 1 on the way to solve this issue is
So, I've changed the most of calls of
randomValue()but some other calls look fine without changing.