Add shadow for Heroes Meeting dialog #9666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Window, Heroes::MeetingDialog and Battle::PopupDamageInfo. Revert code for Battle::PopupDamageInfo::_makeDamageImage()
Districh-ru
added
improvement
Districh-ru
requested changes
Mar 21, 2025
There was a problem hiding this comment.
Hi @Furiiis, the shadow looks great!
I left three comments, could you please check them when you have time?
Districh-ru
requested changes
Mar 21, 2025
There was a problem hiding this comment.
@Furiiis, I left one more comment I missed during the previous review. Could you please check it.
oleg-derevenetz
approved these changes
Mar 28, 2025
|
Technically, this PR looks fine, but GitHub won't allow it to be merged until @ihhub clears his "changes requested" status. |
ihhub
approved these changes
Mar 28, 2025
|
@Furiiis , many thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #7106
Previous pr with duscussions: #9654
I moved the shadow generation from
StandardWindow::render()to new function -addShadowForRectangularDialog().StandartWindow,Heroes::MeetingDialogandBattle::PopupDamageInfoare using this function