Add German language support for Virtual Keyboard

[roman-yagodin]

Relates to #8826

The button for "ß" (Eszett) placed in the 3rd row - should be right of "0" in a numeric row on real keyboard.

More importantly, button for "ß" is missing its glyph - where are no such glyph in the font?..
Where in code/resources should I look to address that?

[ihhub]

Hi @roman-yagodin , all letters are generated by the engine. You can take a look at ui_font.cpp file, generateCP1252GoodButtonFont() function.

[roman-yagodin]

Thanks, I will look into it.

[roman-yagodin]

Screenshot with the brand-new "ß" letter on button:

Enlarged:

Hope it will be in a row with rest of the style!

[ihhub]

Hi @roman-yagodin , I assumed that this pull request is ready for review so I added reviewers here.

[ihhub]

Hi @zenseii , would you mind to review this pull request if you have time these days?

[zenseii]

@ihhub. I'll properly review this and other PRs today as I have a bit more time.

[zenseii]

Great job, @roman-yagodin. I left a small comment for improvement with some hopefully useful advice.

[ihhub]

Hi @roman-yagodin , if you would be able to update the pull request by today then we can merge it to the upcoming release.

[ihhub]

Hi @zenseii , would you be able to help with the change you requested here?

[zenseii]

@roman-yagodin, I made the suggested commit and solved the merge conflicts.

[roman-yagodin]

OK, thanks @zenseii !

I did some experiments and simply decreasing the sprite width will result in the symbol not being properly centered on the button (a little to the right than I've originally intended):

In order to fix this, we need to move entire symbol by -1px along X axis. This will move first drawing point to (offset - 1, offset + 9), which is effectively inside 2px offset frame. I'm not sure is it acceptable or not.

Another option would be just to leave 15 + offset * 2 width as in my original commit... 😄

[zenseii]

@roman-yagodin, you can use the same format for offsetting buttons on the x-axis and y-axis as we do in the for loop in the top of the function. We do this for the A symbol for example.

[zenseii]

Actually scratch that last idea. That won't work. It will only move the letter in relation to other letters.