Replace "gold only" chest dialog with "gold or exp" one in case when hero has no space for an artifact #9607
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
ihhub
added
improvement
There was a problem hiding this comment.
Hi @roman-yagodin , I left few comments here. Could you please take a look when you have time?
| @@ -1835,24 +1849,12 @@ namespace | |||
| const Artifact & art = getArtifactFromTile( tile ); | |||
|
|
|||
| if ( gold ) { | |||
There was a problem hiding this comment.
We need to do the same change for the AI in void AIToTreasureChest() function.
There was a problem hiding this comment.
Hi @roman-yagodin , we haven't addressed this comment. We have to do the similar changes for the AI as well.
There was a problem hiding this comment.
OK, I will look at it.
There was a problem hiding this comment.
@ihhub, I've made some changes to AIToTreasureChest() function, but not sure I understand all ins and outs. Could you please check it out and give me some further directions? I wonder how it can be tested in first place.
|
OK, sure. |
in case when hero has no space for an artifact
- pass gold param via reference, - standardize msg var declaration, - move function code up the source
roman-yagodin
force-pushed
the
issue-9546
branch
from
116bbb1 to
6aeb707
Compare
|
Hi @roman-yagodin , if you would be able to update the pull request by today then we can merge it to the upcoming release. |
…no place for an artifact
This will resolve #9546.