Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the Belarusian Translation #9593

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

Krajovy
Copy link

@Krajovy Krajovy commented Feb 24, 2025

No description provided.

@zenseii zenseii added improvement New feature, request or improvement translation Things related to languages and translations labels Feb 24, 2025
@zenseii zenseii added this to the 1.1.7 milestone Feb 24, 2025
@zenseii zenseii requested a review from Branikolog February 24, 2025 15:46
Copy link
Collaborator

@zenseii zenseii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @Krajovy. Thank you for this contribution. I left some comments. Please have a look.

@zenseii zenseii changed the title Update be.po Update the Belarusian Translation Feb 26, 2025
I corrected the above mentioned by the @zenseii, and also added more text.
@zenseii zenseii self-requested a review February 26, 2025 21:07
@Krajovy
Copy link
Author

Krajovy commented Mar 2, 2025

@zenseii I still haven't figured out what other code changes are needed?

@zenseii
Copy link
Collaborator

zenseii commented Mar 2, 2025

@zenseii I still haven't figured out what other code changes are needed?

Hi, @Krajovy. You added a lot of new translations and this takes time for the team to review. We will comment here once we have finished reviewing and I would suggest to not add anything new here in the meantime. If you want to continue translating and you are familiar with how git works, then you can open a new branch and continue your work there.

Copy link
Owner

@ihhub ihhub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Krajovy, I put multiple comments here. Would you mind to take a look at them?


msgid ""
"Toggle the hex grid on or off. The hex grid always underlies movement, even "
"if turned off. This switch only determines if the grid is visible."
msgstr ""
"Паказаць/схаваць сетку поля бою. Усе перамяшчэнні на полі бою адбываюцца па "
"гексаганальнай сетцы. Гэты параметр уплываае толькі на знешні выгляд поля "
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think уплываае is misspelled.


msgid "Skip this unit"
msgstr ""
msgstr "Прапусціць гэты ход"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not entirely accurate as unit is not translated as ход. ход is turn which equals to round. Should it be Прапусціць ход атрада?


msgid "Reset to default settings."
msgstr ""
msgstr "Скінуць да стандартных наладаў"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add missing full stop at the end of the sentence.

Comment on lines +1331 to +1332
"Вы павінны аб'яднаць варварскія плямёны поўначы, заваяваўшы іх. Як і ў "
"папярэдняй місіі, ворагі не аб'яднаны супраць вас, але пад іх кантролем "
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that we are mixing symbols ' like here and at line 1227. We must be consistent. I believe is the correct one.

Comment on lines +1354 to +1355
"Арчыбальда. У шэрагах Роланда не адзін герой, а мноства гарадоў даюць ім "
"магчымасць пачаць атаку з некалькіх кірункаў, таму будзьце напагатове! Вы "
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The meaning of:

У шэрагах Роланда не адзін герой, а мноства гарадоў даюць ім магчымасць пачаць атаку
з некалькіх кірункаў, таму будзьце напагатове!

is different from what it supposes to be:

У шэрагах Роланда больш чым адзін герой і мноства гарадоў, якія даюць магчымасць
пачаць атаку з некалькіх кірункаў, таму будзьце напагатове!

What do you think?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will take this into consideration. Thanks for your comments.


msgid ""
"Play a Hot Seat game, where 2 to 6 players play around the same computer, "
"switching into the 'Hot Seat' when it is their turn."
msgstr ""
"Гуляй за адным кампутарам з адной-пяццю іншымі асобамі, перадаючы кіраванне "
"па чарзе."
"Гуляйце за адным камп'ютарам з адным-пяццю іншымі гульцамі, перадаючы "
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here we should use symbol instead of '.

"\n"
"\n"
"Каб зымітаваць націсканне правай кнопкі мышы на сэнсарным экране, для "
"атрымання інфармацыі пра розныя аб'екты ў гульні, Вам трэба спачатку "
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here we should use symbol instead of '.

"націснуць на аб'ект, які Вас цікавіць, а потым, утрымліваючы націсканне, "
"дакрануцца любога іншага месца на экране другім пальцам. Утрымліваючы другі "
"палец, вы можаце прыбраць першы з экрана і працягнуць прагляд інфармацыі пра "
"аб'ект."
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here we should use symbol instead of '.


msgid "Your hero has %{sp} spell points remaining out of %{max}."
msgstr ""
msgstr "У Вашага героя засталося %{sp} ачкоў магіі з %{max}."
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that we are mixing capital and non-capital first letter for word Вы. Is it intentional?

@ihhub
Copy link
Owner

ihhub commented Mar 10, 2025

Hi @Krajovy , could you please revert the last commit as this pull request became too big to review? Let's focus only on existing lines which we reviewed. Then in a next pull request we review the other portion.

@Krajovy
Copy link
Author

Krajovy commented Mar 10, 2025

Hi @Krajovy , could you please revert the last commit as this pull request became too big to review? Let's focus only on existing lines which we reviewed. Then in a next pull request we review the other portion.

I don't really understand the GitHub interface. Could you please tell me how to do this?

@ihhub
Copy link
Owner

ihhub commented Mar 12, 2025

Hi @Krajovy , I did this for you. GitHub does not allow to do this within the website.

@ihhub
Copy link
Owner

ihhub commented Mar 12, 2025

@Krajovy , let's just fix the existing lines without touching ' symbol.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement New feature, request or improvement translation Things related to languages and translations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants