Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add button shine to more buttons #9471

Merged
merged 25 commits into from
Jan 26, 2025
Merged

Add button shine to more buttons #9471

merged 25 commits into from
Jan 26, 2025
+163 −296

Conversation

zenseii
Copy link
Collaborator

@zenseii zenseii commented Jan 19, 2025 •
edited
Loading

OKAY button, custom normal buttons (see virtual keyboard, most editor buttons), yes and no buttons, learn, gift

Did some code tidying of several dialogs which will allow them to have resized OKAY buttons with proper shadows:

  • graphic settings
  • system settings
  • adventure map settings
  • editor settings
  • audio settings
  • battle settings
  • Necromancy! dialog
    map select
    scenario info

@zenseii
Remove use of smaller OKAY button
823fd79 
Only present in Necromancy! dialog. Rework Necromancy! dialog. Change to text adaptive button for OKAY button
@zenseii
Add button shine to custom normal buttons
6214a60 
Affects V-keyboard, editor dialog buttons and many others
@zenseii
make common animation helper functions
4ea64e8
@zenseii
Rework settings dialog
0befc3a 
Need to add shadows under each option
@zenseii zenseii added improvement New feature, request or improvement ui UI/GUI related stuff labels Jan 19, 2025
@zenseii zenseii added this to the 1.1.6 milestone Jan 19, 2025
@zenseii zenseii changed the title Add more button shine Add button shine to more buttons Jan 21, 2025
@zenseii zenseii marked this pull request as ready for review January 21, 2025 22:03
@zenseii zenseii requested review from Districh-ru and ihhub January 21, 2025 22:04
Districh-ru
Districh-ru requested changes Jan 25, 2025
View reviewed changes
Copy link
Collaborator

@Districh-ru Districh-ru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @zenseii, I like the new shiny buttons!
I left several comments, could you please check them when you have time?

src/fheroes2/dialog/dialog_audio.cpp Outdated Show resolved Hide resolved
src/fheroes2/dialog/dialog_audio.cpp Outdated Show resolved Hide resolved
src/fheroes2/dialog/dialog_audio.cpp Outdated Show resolved Hide resolved
src/fheroes2/dialog/dialog_game_settings.cpp Outdated Show resolved Hide resolved
src/fheroes2/dialog/dialog_graphics_settings.cpp Outdated Show resolved Hide resolved
src/fheroes2/editor/editor_options.cpp Outdated Show resolved Hide resolved
@zenseii
Copy link
Collaborator Author

zenseii commented Jan 26, 2025

Thanks, @Districh-ru !

@zenseii zenseii requested a review from Districh-ru January 26, 2025 08:42
Districh-ru
Districh-ru approved these changes Jan 26, 2025
View reviewed changes
Copy link
Collaborator

@Districh-ru Districh-ru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ihhub ihhub merged commit 6915acc into ihhub:master Jan 26, 2025
22 checks passed
@ihhub
Copy link
Owner

ihhub commented Jan 26, 2025

@zenseii , many thanks for these changes!

@zenseii zenseii deleted the more-button-shine branch January 26, 2025 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Districh-ru Districh-ru Districh-ru approved these changes

@ihhub ihhub ihhub approved these changes

Assignees

@zenseii zenseii

Labels
improvement New feature, request or improvement ui UI/GUI related stuff
Projects
None yet
Milestone
1.1.6
Development

Successfully merging this pull request may close these issues.
3 participants
@zenseii @ihhub @Districh-ru