-
-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Further fixes and improvements related to WebAssembly #9444
Draft
oleg-derevenetz
wants to merge
19
commits into
ihhub:master
Choose a base branch
from
oleg-derevenetz:ems-audio-pump-fix
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+127
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleg-derevenetz
added
improvement
New feature, request or improvement
Wasm
WebAssembly version of the engine
labels
Jan 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm currently running Wasm build of fheroes2 (with threads) in the browser (Chromium-based) in the AI auto control mode for a few hours, and I should say that the situation with playing background music has improved significantly. The only strange thing is that immediately after starting the game and when loading the first map, the memory consumption of the corresponding browser tab increases sharply from ~500Mb to 5-6Gb for several seconds ( and during this time music is played intermittently). After a few seconds, the memory consumption drops back to ~500Mb, and loading of other maps (or the same map) no longer causes such an effect, memory consumption is not growing anymore. This is very similar to the GC behavior, which means that some JavaScript code is most likely eating up memory (not the fheroes2 itself).
P.S. What's interesting, there is no such an effect in the Firefox.