Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update background image for PSV version of the engine #9418

Merged
merged 4 commits into from
Jan 7, 2025

Conversation

ihhub
Copy link
Owner

@ihhub ihhub commented Jan 6, 2025

To reflect the correct name of the project.

To reflect the correct name of the project.
@ihhub ihhub added the bug Something doesn't work label Jan 6, 2025
@ihhub ihhub added this to the 1.1.6 milestone Jan 6, 2025
@ihhub ihhub self-assigned this Jan 6, 2025
@ihhub ihhub requested a review from oleg-derevenetz January 6, 2025 14:05
@ihhub
Copy link
Owner Author

ihhub commented Jan 6, 2025

Hi @Districh-ru , could you please test these changes on the emulator to confirm that files\images\platform\psv\background.png was not needed at all in the first place?

@ihhub ihhub requested a review from Districh-ru January 6, 2025 14:16
@ihhub
Copy link
Owner Author

ihhub commented Jan 6, 2025

Hi @Northfear, can you please check that the removed files\images\platform\psv\background.png file was not needed? Just try to run on the device and check the application icon and the background image are present.

Copy link

sonarqubecloud bot commented Jan 6, 2025

@Districh-ru
Copy link
Collaborator

Districh-ru commented Jan 6, 2025

Hi, @ihhub, it is OK on my emulator:

изображение

And could you please revert this change 36d4df3 ?
Previously I tested it on emulator and proposed it.
But unfortunately the real PS Vita hardware does not like our versioning format and fails with 0x080101104 error (reported by Pønytail on Discord).
For PS it should be "xx.yy" (two digits, dot, two digits). But for now lets leave it empty (00.00) and later think how to convert our versions to PS supported version format.

@oleg-derevenetz
Copy link
Collaborator

Hi @Districh-ru

But unfortunately the real PS Vita hardware does not like our versioning format and fails with 0x080101104 error (reported by Pønytail on Discord).
For PS it should be "xx.yy" (two digits, dot, two digits). But for now lets leave it empty (00.00) and later think how to convert our versions to PS supported version format.

I'll try to address this issue in #9423. So far, I'm thinking about whether it's possible to implement some elegant error handling, as soon as it's ready, I'll ask for a review.

@ihhub ihhub merged commit 7ff29c3 into master Jan 7, 2025
21 checks passed
@ihhub ihhub deleted the psv-background-image branch January 7, 2025 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something doesn't work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants