Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some of the HTML errors reported by SonarQube #9414

Merged
merged 2 commits into from
Jan 6, 2025
Merged

Conversation

oleg-derevenetz
Copy link
Collaborator

@oleg-derevenetz oleg-derevenetz commented Jan 5, 2025

  • Add the <!DOCTYPE html>;
  • Remove the text-stroke CSS property. This property is non-standard and should be used with the -webkit- vendor prefix only (and property with the correct name is already in use).

@oleg-derevenetz oleg-derevenetz added bug Something doesn't work Wasm WebAssembly version of the engine labels Jan 5, 2025
@oleg-derevenetz oleg-derevenetz added this to the 1.1.6 milestone Jan 5, 2025
Copy link

sonarqubecloud bot commented Jan 5, 2025

@oleg-derevenetz oleg-derevenetz marked this pull request as ready for review January 5, 2025 20:08
@oleg-derevenetz oleg-derevenetz requested a review from ihhub January 5, 2025 20:08
@ihhub ihhub merged commit e6181f1 into master Jan 6, 2025
22 checks passed
@ihhub ihhub deleted the html-errors branch January 6, 2025 00:09
@ihhub
Copy link
Owner

ihhub commented Jan 6, 2025

@oleg-derevenetz , thank you so much for these corrections!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something doesn't work Wasm WebAssembly version of the engine
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants