Improved morale ui when all troops are undead #9398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the player has an undead army, the moral does not apply. The issue is that the info is still (partially calculated) and displayed. The artifacts are taken into consideration but not the skills / tavern. With this commit the morale is always calculated & displayed in the hero menu.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
oleg-derevenetz
added
improvement
ihhub
approved these changes
Jan 9, 2025
|
@felix642 , many thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The morale modifier is now calculated when using an undead army. The previous behaviour was inconsistent depending on where the modifier was coming from (artifact vs hero).
Grayed out the morale icon if the hero is using an undead army.
fixes #2419