Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 3 new variants of Observation Tower object #9379

Merged
merged 2 commits into from
Dec 28, 2024

Conversation

ihhub
Copy link
Owner

@ihhub ihhub commented Dec 25, 2024

All credits go to PushPop from Discord.

image

image

@ihhub ihhub added improvement New feature, request or improvement ui UI/GUI related stuff logic Things related to game logic editor Map editor related stuff labels Dec 25, 2024
@ihhub ihhub added this to the 1.1.5 milestone Dec 25, 2024
@ihhub ihhub self-assigned this Dec 25, 2024
@ihhub ihhub marked this pull request as draft December 25, 2024 05:46
@ihhub ihhub marked this pull request as ready for review December 25, 2024 06:11
Copy link
Collaborator

@Districh-ru Districh-ru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @ihhub,
I like how the new objects look! Many thanks, PushPop!

I left a comment regarding the passability of the Desert and Snow towers. Could you please take a look?

src/fheroes2/maps/map_object_info.cpp Outdated Show resolved Hide resolved
src/fheroes2/maps/map_object_info.cpp Outdated Show resolved Hide resolved
@ihhub ihhub requested a review from Districh-ru December 27, 2024 12:50
@ihhub ihhub merged commit 617f657 into master Dec 28, 2024
21 checks passed
@ihhub ihhub deleted the new-observation-tower-variants branch December 28, 2024 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editor Map editor related stuff improvement New feature, request or improvement logic Things related to game logic ui UI/GUI related stuff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants