-
-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to set spells in Shrine in the Editor #9347
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clang-Tidy
found issue(s) with the introduced code (1/1)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, @ihhub, well done! 👍
I left one optional suggestion, could you please take a look in you spare time?
Also later (in a new PR) we can optimize spells rendering not to fully redraw all spells and scrolls on the single spell change. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clang-Tidy
found issue(s) with the introduced code (1/1)
Quality Gate passedIssues Measures |
Hi @Districh-ru , I merged this pull request as I would like to add functionality for Pyramid before the release. Please let me know if you have any further comments so I could address them in the new pull request. |
Hi, @ihhub, I've checked the updated code and all is OK. I like that now it correlates with the editor's code so it'll be easier to maintain the same looking logic. :) |
this pull request should be merged after #9335