-
-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix text input cursor setting for multi-line text input with many spaces at the line end #9319
Fix text input cursor setting for multi-line text input with many spaces at the line end #9319
Conversation
Hi, @ihhub! |
This formatting is because |
Thanks for clarifying, @oleg-derevenetz! |
Hi @Districh-ru
There is no need to create symlinks, MSVC can use a custom |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Districh-ru , I left 2 comments here. Can you please take a look at them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Districh-ru , I took another round of review of this pull request as @Branikolog hasn't reviewed yet. I left few suggestions for improvements. Could you please take a look at them?
@Districh-ru , I made the tests myself. Everything works perfect. Thank you! |
This PR fixes the issue with setting input cursor position when there are many spaces in multi-line text input: #9281 (comment)
Now the multi-line text input field acts like in the original editor - is does not cut spaces at the line end to show user that there are many spaces there and to allow position the cursor at any place of such consequent spaces.
This PR also:
getTextInputCursorPosition()
toui_tool
;-
master build:
this PR: