Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Turkish Translation. #9308

Merged
merged 7 commits into from
Dec 4, 2024
Merged

Updated Turkish Translation. #9308

merged 7 commits into from
Dec 4, 2024

Conversation

WeirdYunus
Copy link
Contributor

Mainly updated the UI and some first story text, making it more understandable for turkish players compared to the previous translation. Fixed some wrong translations from the previous one. The amount of lines changed is a bit above the limit but that's mainly because most strings are using space or \n and I can't see the line count on the translation software. I'll try to be more careful next time.

@oleg-derevenetz oleg-derevenetz added improvement New feature, request or improvement translation Things related to languages and translations labels Dec 1, 2024
@oleg-derevenetz oleg-derevenetz added this to the 1.1.5 milestone Dec 1, 2024
files/lang/tr.po Outdated Show resolved Hide resolved
@WeirdYunus
Copy link
Contributor Author

I hope everything is alright now. Don't really know how to use Github properly x)

Copy link
Collaborator

@zenseii zenseii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some more formatting errors. I haven't looked at the actual translations yet.

files/lang/tr.po Outdated Show resolved Hide resolved
files/lang/tr.po Outdated Show resolved Hide resolved
files/lang/tr.po Outdated Show resolved Hide resolved
files/lang/tr.po Outdated Show resolved Hide resolved
@WeirdYunus
Copy link
Contributor Author

Oof, I should've been more careful about these. I even forgot the text to test the letters. Sorry if I wasted your time. I'm closing this PR and will post a better polished one anytime soon. I really apologize

@WeirdYunus WeirdYunus closed this Dec 1, 2024
@zenseii
Copy link
Collaborator

zenseii commented Dec 1, 2024

Oof, I should've been more careful about these. I even forgot the text to test the letters. Sorry if I wasted your time. I'm closing this PR and will post a better polished one anytime soon. I really apologize

There is really no need to close the PR. These are just beginner mistakes which is part of the reason why we have the limit of 30 lines changed for a first-time PR.

I would prefer if we reopen this PR and then continue the work from there.

@WeirdYunus WeirdYunus reopened this Dec 1, 2024
Fixed the addressed issues and reviewed the lines that I translated. Whoever did the last translation, they did lots of translation and formatting errors. Those can be ignored for now and I will be fixing them later. For now, I wanted to focus on translating the UI and some of the early game so the player can at least start their adventure.
@zenseii zenseii requested review from zenseii and ihhub December 1, 2024 14:39
Copy link
Collaborator

@zenseii zenseii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only found one comment, @WeirdYunus. Please have a look when it is convenient for you.

Also, please only address the comments we make so that we can merge this PR sooner.

files/lang/tr.po Outdated Show resolved Hide resolved
Fixed typo
Copy link
Collaborator

@zenseii zenseii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!

@ihhub ihhub merged commit 1f9c244 into ihhub:master Dec 4, 2024
19 checks passed
@ihhub
Copy link
Owner

ihhub commented Dec 4, 2024

@WeirdYunus , thank you so much for your contribution to the project!

@zenseii
Copy link
Collaborator

zenseii commented Dec 4, 2024

@WeirdYunus. I will make a PR with the missing Turkish letters very soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement New feature, request or improvement translation Things related to languages and translations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants