Update German translations related to artifacts

[felix-schneider]

Notes:

• (German) As per the discussion in Similar items share translation strings, which is inappropriate for languages with gendered nouns #9260, the definite article is now part of the artifact name.
  • (German) As part of this, normal grammar would demand that an adjective that is part of the artifact name would not be capitalized, as it is no longer at the start of the string (such as "Immervoller Erzkarren" vs. "Der Immervolle Erzkarren"). Looking at this in-game, this just looked weird to me, like it's just any old ever-full ore cart? It's THE ever-full ore cart! So I capitalized the adjectives as well. In cases of proper nouns, this is acceptable (c.f. the popular German TTRPG "Das Schwarze Auge").
• (English) Pickup text for medal of Valor refers to "a" Medal of Valor (note capitalization). In other texts, when artifacts are reffered to by name, they are called "the" artifact.
  • Same for Medal of Courage and Medal of Honor, but not Medal of Distinction
• (English) Ultimate Crown description refers to basic skills. Shoudn't they be called primary skills? (as opposed to the secondary skills) Basic skills could be confused with secondary skills at the basic level (so one could think the crown upgrades those to advanced)
  • Ultimate Scepter calls them attributes, which is also quite rare
• (English) In the Medal of Distinction pickup text, the word "Knights" is capitalized. Is this meant to refer to heros of the Knight faction?
• (English) The English artifact description usually refer to "the hero", whereas the German ones (in the OG also) refer to you directly.
• (English) The Skullcap description refers to "all mind-influencing spells", whereas it should be "all mind-influencing spells you cast", it does not make your enemy's spells cheaper. Also, it's just a skullcap? Like that is an actual thing that exists. It doesn't have any adjective to make it magical, you're just wearing a Kippa?
• (English) The Evil Eye has for some reason a different wording on its description than the Skullcap and the Snake-Ring. It says "reduced by half" and the others save "halves".
• (German) I went with the shorter translation of spell as "Zauber" instead of the "Zauberspruch" from the OG. Especially when used as part of a compound, it leads to really long words. Until we have some kind of dynamic hyphenation, the long words do not render very nicely.
• (German) While I'm not touching spells in this PR, the Wand of Negation mentions Dispel Magic. I never really like the translation of that spell as "Magie zerstreuen", which is really long, especially the mass version. I instead translated it as "Gegenzauber" - Counterspell. Side note: Even the translators of Magic the Gathering did not find an adequate equivalent of the word "dispel" in German. The Magic card "Dispel" is called "Bannzauber" - "Banish spell" in German.
• (Both) The resource-generating artifacts have a replacement string for the amount, but they all say %{count} unit (singular), so if that amount ever changes, the string needs to be edited anyway, so why bother having it?
• (English) The Staff of Wizardry says "boosts your spell power" whereas all other artifacts say "increases your spell power"
• (German) German does not use the same quotation marks as English. In English, you use upper quotation marks (\u0022 or more correctly \u201C and \u201D) at the start and end of a direct quote. In German, at the start of a quotation, you would use the "low double comma" \u201E at the start and upper double quotes \u201C at the end. Both of those can be represented in CP1252 (0x84 and 0x93, respectively), but sadly it looks like the in-game font has no glyphs for them. The OG seems to actually use single quotes (actually apostrophes, \u0027) in some cases (e.g. the spell scroll). I have not followed this example and used \u0022 instead.

[felix-schneider]

After further discussion on discord, I decided to go back and compare the translations more closely against the original game. Please don't merge this yet.

[ihhub]

Hi @felix-schneider , in the future if you would like to prevent a pull request being merged you can use Convert to draft option which does this and also indicates that the pull request needs some work.

Once all work is done you can use the Ready to review button.

[ihhub]

Hi @felix-schneider , what do you think if we merge some of changes from this pull request? I think it is better to have some progress than none.

[felix-schneider]

Sorry, as it is so often, real life prevented me from working more. I have more or less finished it now.

Here are notes for the second pass:
Notes (part 2):

• Went back and matched the original strings more closely
  • While I don't consider them sacred scripture and can find better translations some of the time, I want to stick more or less close to the OG. This project is in no small part about nostalgia, and maybe someone remembers a particular description fondly.
• This has caused me to revert some translations, but not all of them.
  • Thunder Mace of Dominion - Donnerkolben der Herrschaft (was Donnerstab). It's neither a staff (Stab) nor a mace (Streitkolben), it's a flail (Flegel), but we already have one of those (see below)
  • Giant Flail of Dominion - Riesenflegel der Herrschaft (was Riesenpeitsche). It's technically a Mangual. It's definitely not a whip (Peitsche).
  • True Compass of Mobility - Der Unfehlbare Kompass der Mobilität (was Wahrer Kompass). It's not true because there is a False Compass of Mobility, it's true because it never fails to point north. There is no direct equivalent in German, so it's infallible (unfehlbar).
  • The German translators felt it necessary to end the description for the wizard's hat with an exclamation point. That's cute, so I kept it.
• The two types of mobility boots share a description. Luckily, they do not share this with other mobility items, like the compass, because the description would not fit: The boots are in plural, the compass is not.
• I adjusted some descriptions for (my subjective) clarity.
• The telescope description also has a placeholder for the number of squares, but the text is in singular, so if this is changed, the text would need to be changed anyway.
• In the German OG, each artifact actually has several versions of the name: The full name and a short name. In the hero screen, the tooltip is actually titled with the shortened name, with a subtitle explaining the bonus the artifact gives, but only for artifacts with a simple stat bonus. I quite like that, we should have it be like that. The game does not support this at this time.