Set the PROJECT_VERSION for PSV in XX.YY format #9423
Conversation
oleg-derevenetz
added
bug
|
Hi, @oleg-derevenetz, this PR works good on emulator: I've asked Pønytail to test this build on his hardware. |
As far as I understand, on emulator everything works fine even without this PR? :) |
Yes, the emulator reads the version string and displays it (as a string) when installing and then in the applications list: The real hardware, I think, does some version analysis which needs |
|
Hi, @lovenemesis, this PR should fix the issue you have encountered on PS Vita. |
|
It looks like noone wants to get the fheroes2 running on PSV :) Is it worth to still support this platform? :) |
|
Well, yes and no :) However, we should reduce the priority for fixing bugs for this platform. |
|
@oleg-derevenetz , thank you so much for this fix! |
Related to #9418 (comment)
Still can not detect some type of errors - e.g. the absence of
version.txtitself (will set the version to 00.00 in this case), because GNU Make runs the shell inshmode, which doesn't support thebashextensions - e.g. the-o pipefailoption, but it's still better than no error handling at all.