Don't run Docker manually

ihhub · Jan 3, 2025 · a4f870f · a4f870f
1 parent 82ef673
commit a4f870f
Showing 1 changed file with 8 additions and 2 deletions.
diff --git a/.github/workflows/make.yml b/.github/workflows/make.yml
@@ -345,16 +345,22 @@ jobs:
   make-emscripten:
     name: Make (Emscripten)
     runs-on: ubuntu-latest
+    container: emscripten/emsdk:3.1.74
     timeout-minutes: 30
     defaults:
       run:
         shell: bash
     steps:
     - uses: actions/checkout@v4
+    - name: Install dependencies
+      run: |
+        sudo apt-get -y update
+        sudo apt-get -y install gettext p7zip-full
     - name: Build
       run: |
-        docker run --rm -v "$(pwd):/src" -e FHEROES2_STRICT_COMPILATION=ON emscripten/emsdk:3.1.74 \
-            sh -c "apt-get -y update && apt-get -y install gettext && emmake make -f Makefile.emscripten -j \"$(nproc)\""
+        emmake make -f Makefile.emscripten -j "$(nproc)"
+      env:
+        FHEROES2_STRICT_COMPILATION: ON
     - name: Create package
       run: |
         # Translations and H2D files are already included in fheroes2.data