-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Editor metadata #203
Open
Oblomov
wants to merge
7
commits into
ihabunek:master
Choose a base branch
from
Oblomov:editor-metadata
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Editor metadata #203
Commits on Apr 30, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 0591dc6 - Browse repository at this point
Copy the full SHA 0591dc6View commit details -
Implement comment metadata support in editor
This allows setting some properties of the toot directly while editing the message. It is backwards-compatible with the use of # for comment lines and forwards-compatible with the introduction of new metadata comments in the future. The supported ones are listed in the explanatory message appended to the text in the editor.
Configuration menu - View commit details
-
Copy full SHA for 310fef1 - Browse repository at this point
Copy the full SHA 310fef1View commit details -
Support more metacomments and introduce some validation effort
In case of errors, the composed toot is fed back into the editor, including a message about what went wrong.
Configuration menu - View commit details
-
Copy full SHA for 56ee754 - Browse repository at this point
Copy the full SHA 56ee754View commit details -
Add sensitive to metacomments and proper roundtrip
The command-line arguments are reset so that if the corresponding metacomment is removed the default value for the parameter is used again. This ensures that the output from the editor is consistent.
Configuration menu - View commit details
-
Copy full SHA for 9b050cf - Browse repository at this point
Copy the full SHA 9b050cfView commit details -
Configuration menu - View commit details
-
Copy full SHA for aa36aa5 - Browse repository at this point
Copy the full SHA aa36aa5View commit details -
Remove comment support and switch to YAML-style header metadata
As discussed on IRC, remove the filtering of lines starting with a hash-sign. This allows pasting snippets of code that with # as comment symbol, and allows hashtags to start on an empy line. Metadata support is moved to a YAML-style header similar to what Jekyll uses. We don't go full YAML though, just a simple key: value syntax (the same as before, but without the # in front).
Configuration menu - View commit details
-
Copy full SHA for b61d6cc - Browse repository at this point
Copy the full SHA b61d6ccView commit details
Commits on May 1, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 7a8ac7c - Browse repository at this point
Copy the full SHA 7a8ac7cView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.