Adds adaptive speed functionality #583

newice · 2020-01-27T09:22:45Z

Press A to toggle adaptive speed.
The speed then increases to double the preferred speed if video is silent and goes back to preferred speed if it is not silent anymore.

Press A to toggle adaptive speed. The speed then increases to double the preferred speed if video is silent and goes back to preferred speed if it is not silent anymore.

ChadBailey

I really like this feature, thanks so much for the time you put into it!

Sorry for the delay getting it merged, there are a couple of things holding it back that have nothing to do with the request itself so please be patient with us!

First is the big one, #595 has to be resolved before we can merge. Once that's done, I'm sure we'll have some merge conflicts that we'll have to work through.

Second one, I haven't had the chance to pull this and test it to make sure it works on a handful of the usual big websites from my machine.

Thanks for your contribution and patience!

ChadBailey · 2020-02-18T03:08:00Z

inject.js

        }
      }
    });
  }

+  function toggleAdoptiveSpeed(v, controller) {


I think you may have meant to name this toggleAdaptiveSpeed

You are right.

ChadBailey · 2020-02-18T03:15:01Z

inject.js

+          tc.adaptiveSpeedAnalyserNode.getFloatFrequencyData(myDataArray);
+          var dbValue = Math.max(...myDataArray) + 100;
+          var quietZone = 45;
+          var eps = 4;


What does eps stand for?

I Thought of Machine epsilon. https://en.wikipedia.org/wiki/Machine_epsilon
But i think it should be named different. I just wanted to have a buffer zone so the speed does not jump around all the time.

ChadBailey · 2020-02-27T03:12:16Z

I tried this out as-is without updating it, and I can't seem to get it to work? Can you provide steps for testing?

ChadBailey · 2020-03-26T17:59:06Z

All of the big changes that required this to be put on hold are behind us now. I've slated for 0.7 release if we can get it worked out before then. @newice Can you confirm with me how I can test this enhancement?

newice · 2020-03-29T21:57:37Z

How to test the enhancement:

It does not work on Firefox(https://bugzilla.mozilla.org/show_bug.cgi?id=1517199) , only in chrome
The key "A" triggers adaptive speed on and off.

Nothing else needed to set up.. @ChadBailey Did you have any errors in the console? I also addad a new button to the overlay controls. you can click it instead of the key.

ChadBailey · 2020-03-30T00:42:45Z

Nothing else needed to set up..

I was able to activate it, but in my tests it didn't actually do anything. I assume maybe it was just the lack of sufficient silence in the videos I tried? I'm unsure. This is why I was hoping for exact steps, like set the settings this way, go to this website, activate, from 0:00-1:50 you should see 1x speed, from 1:50-1:55 you should see 2.5x speed, etc.

newice · 2020-03-30T06:25:38Z

This video is silent between the speaking: https://www.youtube.com/watch?v=kcs82HnguGc

Start the Video
Hit 'A' ==>When you activate adaptive speed the speed should go from 1 to prefered speed (in my case 1.8)
As soon as the speaker stops talking the Speed switches to 2x preferred (in my case 3.6)
while active you can not change the speed because it gets resetted by adaptive speed.
When you deactivate adaptive speed it jumps to preferred speed (in my case 1.8).

Youtube hides the controls so you maybe don't see the change. Keep the mouse over the video moving to always see the current speed.

ChadBailey · 2020-04-13T06:02:21Z

thanks for the steps for testing. sorry for the delays in getting back to you, i've been busy with COVID-19 related tasks. i plan to test this soon

newice · 2020-08-03T09:08:30Z

Finally i was able to update my pullrequest. So if anyone has the time i would appreciate a feedback.

Instead of using Preferred Speed as the normal speed, use lastSpeed. So the user has the full control on which speed to watch and still the silent parts are fast forwarded at adaprive speed.

igrigorik · 2020-09-12T22:45:40Z

@newice this is, fascinating! I took for a quick test drive, a few questions..

On YouTube my video periodically flashes to 0.0 (full pause) and then resumes -- guessing, that's not intended behavior?
Have you done any testing on what the CPU impact is when this is enabled?

while increased speed is active due to low audio level

newice · 2020-10-01T22:10:55Z

@newice this is, fascinating! I took for a quick test drive, a few questions..

On YouTube my video periodically flashes to 0.0 (full pause) and then resumes -- guessing, that's not intended behavior?

This is strange. I never had the speed go to 0.0 For the silent phases i changed the speed from two times the prefered speed to an own setting whichyou can set in the plugin options. Default is 3. Maybe the setting is missing for some reason?

Have you done any testing on what the CPU impact is when this is enabled?

No unfortunately i have no experience in extended performance testing. activating the adaptive speed for the first time after page load usually takes about 0.1 second for me.

inject.js

when using adaptive speed

fideliochan · 2024-04-06T18:44:11Z

@newice @igrigorik @ChadBailey update on this please!

Adds adaptive speed functionality

09c4e67

Press A to toggle adaptive speed. The speed then increases to double the preferred speed if video is silent and goes back to preferred speed if it is not silent anymore.

newice requested a review from igrigorik January 27, 2020 09:23

ChadBailey reviewed Feb 18, 2020

View reviewed changes

ChadBailey added question blocked:feedback We are waiting for clarification questions to be answered and removed question labels Feb 27, 2020

ChadBailey added this to the 0.7.0 milestone Mar 26, 2020

ChadBailey added the Testing This issue is in testing, waiting to be merged label Mar 26, 2020

ChadBailey added enhancement Needs Work and removed blocked:feedback We are waiting for clarification questions to be answered labels May 17, 2020

newice added 2 commits August 3, 2020 10:45

merge with upstream

d87c863

merge

33d8323

newice requested a review from ChadBailey August 3, 2020 09:00

Changing speed

b72d474

Instead of using Preferred Speed as the normal speed, use lastSpeed. So the user has the full control on which speed to watch and still the silent parts are fast forwarded at adaprive speed.

newice added 3 commits October 1, 2020 23:06

Merge remote-tracking branch 'igriok/master'

f198f65

Prevent speed change

e1d14cc

while increased speed is active due to low audio level

fixed call of setSpeed

038edff

igrigorik reviewed Jan 22, 2021

View reviewed changes

inject.js Outdated Show resolved Hide resolved

Heckmann, Arthur added 2 commits February 17, 2021 21:24

Merge remote-tracking branch 'upstream/master'

f4ac406

Attempt to not overwrite previous speed

6afd095

when using adaptive speed

madarez mentioned this pull request Jan 31, 2022

Feature Request: Automatic Jump cut mode #445

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adds adaptive speed functionality #583

Adds adaptive speed functionality #583

newice commented Jan 27, 2020

ChadBailey left a comment

ChadBailey Feb 18, 2020

newice Feb 24, 2020

ChadBailey Feb 18, 2020

newice Feb 24, 2020

ChadBailey commented Feb 27, 2020

ChadBailey commented Mar 26, 2020

newice commented Mar 29, 2020

ChadBailey commented Mar 30, 2020

newice commented Mar 30, 2020

ChadBailey commented Apr 13, 2020

newice commented Aug 3, 2020

igrigorik commented Sep 12, 2020

newice commented Oct 1, 2020 •

edited

Loading

fideliochan commented Apr 6, 2024

Adds adaptive speed functionality #583

Are you sure you want to change the base?

Adds adaptive speed functionality #583

Conversation

newice commented Jan 27, 2020

ChadBailey left a comment

Choose a reason for hiding this comment

ChadBailey Feb 18, 2020

Choose a reason for hiding this comment

newice Feb 24, 2020

Choose a reason for hiding this comment

ChadBailey Feb 18, 2020

Choose a reason for hiding this comment

newice Feb 24, 2020

Choose a reason for hiding this comment

ChadBailey commented Feb 27, 2020

ChadBailey commented Mar 26, 2020

newice commented Mar 29, 2020

ChadBailey commented Mar 30, 2020

newice commented Mar 30, 2020

ChadBailey commented Apr 13, 2020

newice commented Aug 3, 2020

igrigorik commented Sep 12, 2020

newice commented Oct 1, 2020 • edited Loading

fideliochan commented Apr 6, 2024

newice commented Oct 1, 2020 •

edited

Loading