Fix GitHub Actions failures and add Ruby 3.3 to CI #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Once this gets merged, I can rerun #358 to confirm the fix. |
MatheusRich
approved these changes
Jan 4, 2024
|
I think you need to migrate from the archived cookiejar gem to the new cookiejar2 gem. |
lawrence-forooghian
added a commit
to ably-forks/em-http-request
that referenced
this pull request
Apr 26, 2024
…x-ci This merges the contents of igrigorik#359 into our fork, in order to fix the broken GitHub workflows. As mentioned in [1], the Ruby 3.3 build is currently failing; we’ll live with this for now. [1] igrigorik#359 (comment)
|
I tried running the actions from this branch on my fork and all of the jobs are passing. Has cookiejar been fixed upstream? |
|
@lawrence-forooghian yes! |
lawrence-forooghian
added a commit
to ably-forks/em-http-request
that referenced
this pull request
Apr 26, 2024
…eate-ably-fork This merges the contents of igrigorik#359 into our fork, in order to fix the broken GitHub workflows.
mattbrictson
force-pushed
the
fix-workflow-typo
branch
from
e940641
to
10a2571
Compare
|
I just triggered CI again and all jobs are now passing in this PR, even Ruby 3.3, thanks to the cookiejar fix upstream. |
|
ty sir! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My initial GitHub Actions CI workflow that I provided in #357 had mistakes that are currently causing it to fail on the master branch.
This PR fixes those failures. I have tested it on my fork, see: https://github.com/mattbrictson/em-http-request/actions/runs/7411502617
The following problems are now fixed:
- usestypolibcurl4-openssl-devdependency so that thecurbgem buildsfail-fast: falseso that one failing Ruby version in the CI matrix doesn't stop the others from runningI also added Ruby 3.3 to the build matrix.
Note that this version currently fails, due to known issues documented in #358.Now fixed.