213 incorrect error message when validator is used with if or on #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's in draft because it's missing the |
Mth0158
force-pushed
the
213-incorrect-error-message-when-validator-is-used-with-if-or-on
branch
from
bd941e9
to
16dc799
Compare
Mth0158
force-pushed
the
213-incorrect-error-message-when-validator-is-used-with-if-or-on
branch
from
a899539
to
6baac5c
Compare
|
@igorkasyanchuk I took the liberty to merge this PR since it only impacts lightly 2 prod files. This PR sets the base for the next test files that will greatly enhance our ability to mitigate regressions :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to the work done in #209
Again, a "big" one, but it's mostly refacto the validator test suite. Only 2 prod files are impacted:
lib/active_storage_validations/limit_validator.rb=> We do not take into account the attached files without blob when counting for validating, @igorkasyanchuk I had to do this to pass the tests with context option, I think this was an edge case? Or is this something that I get wrong?lib/active_storage_validations/size_validator.rb=> We make sure not to take Rails options as key interpolated for i18n