Skip to content

OF-2010 Specify port protocol for Media Proxy#3381

Open
MilanTyagi2004 wants to merge 1 commit into
igniterealtime:mainfrom
MilanTyagi2004:OF-2010
Open

OF-2010 Specify port protocol for Media Proxy#3381
MilanTyagi2004 wants to merge 1 commit into
igniterealtime:mainfrom
MilanTyagi2004:OF-2010

Conversation

@MilanTyagi2004

Copy link
Copy Markdown
Collaborator

Description

The Media Proxy service in Openfire opens UDP listeners, but the corresponding port configuration fields in the Admin Console do not explicitly indicate that these ports use the UDP protocol. This can cause confusion when configuring firewall or network rules.

This change updates the labels of the Media Proxy port configuration fields to clearly indicate that they are UDP ports.

Changes

Updated the default English localization resource file (openfire_i18n.properties):

  • mediaproxy.form.minport: Port Range MinUDP Port Range Min
  • mediaproxy.form.maxport: Port Range MaxUDP Port Range Max
  • mediaproxy.form.echoport: Echo Test PortUDP Echo Test Port

Testing

  • Verified that the project compiles successfully using mvn compile.
  • Verified that the updated labels are displayed correctly on the Media Proxy settings page in the Admin Console.

Notes

This is a UI text-only change. No functional behavior has been modified.

OF-2010

The Media Proxy opens a set of UDP listeners on the server, but this
was not clear from the input labels on the admin console settings page.
To avoid confusion, added "UDP" prefix to the corresponding input labels.

Updated properties in openfire_i18n.properties:
- mediaproxy.form.minport ("UDP Port Range Min")
- mediaproxy.form.maxport ("UDP Port Range Max")
- mediaproxy.form.echoport ("UDP Echo Test Port")
@coderabbitai

coderabbitai Bot commented Jun 5, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 555574e7-9432-42a6-9a8c-d4cc8cd67fa0

📥 Commits

Reviewing files that changed from the base of the PR and between 75c25b0 and 8475a66.

📒 Files selected for processing (1)
  • i18n/src/main/resources/openfire_i18n.properties

📝 Walkthrough

Walkthrough

This PR updates the internationalization (i18n) resource bundle for Openfire by refining three UI labels in the Media Proxy settings to be more specific. The min/max port range fields and echo test port field are now explicitly labeled as UDP-related properties rather than using generic port-related terminology. The changes affect only the English i18n properties file with no modifications to code logic or public APIs.

Suggested reviewers

  • guusdk
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description clearly explains the purpose of the changes, describes the modifications made, and provides context about testing and validation.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@MilanTyagi2004

Copy link
Copy Markdown
Collaborator Author

Hi @guusdk,
changes are unrelated to this CI/CD failure.
please trigger rerun.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant