OF-2010 Specify port protocol for Media Proxy#3381
Conversation
The Media Proxy opens a set of UDP listeners on the server, but this
was not clear from the input labels on the admin console settings page.
To avoid confusion, added "UDP" prefix to the corresponding input labels.
Updated properties in openfire_i18n.properties:
- mediaproxy.form.minport ("UDP Port Range Min")
- mediaproxy.form.maxport ("UDP Port Range Max")
- mediaproxy.form.echoport ("UDP Echo Test Port")
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis PR updates the internationalization (i18n) resource bundle for Openfire by refining three UI labels in the Media Proxy settings to be more specific. The min/max port range fields and echo test port field are now explicitly labeled as UDP-related properties rather than using generic port-related terminology. The changes affect only the English i18n properties file with no modifications to code logic or public APIs. Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Hi @guusdk, |
Description
The Media Proxy service in Openfire opens UDP listeners, but the corresponding port configuration fields in the Admin Console do not explicitly indicate that these ports use the UDP protocol. This can cause confusion when configuring firewall or network rules.
This change updates the labels of the Media Proxy port configuration fields to clearly indicate that they are UDP ports.
Changes
Updated the default English localization resource file (
openfire_i18n.properties):mediaproxy.form.minport:Port Range Min→UDP Port Range Minmediaproxy.form.maxport:Port Range Max→UDP Port Range Maxmediaproxy.form.echoport:Echo Test Port→UDP Echo Test PortTesting
mvn compile.Notes
This is a UI text-only change. No functional behavior has been modified.
OF-2010